Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace at end of line in config reader #624

Open
sethhall opened this issue Oct 4, 2019 · 2 comments

Comments

@sethhall
Copy link
Member

commented Oct 4, 2019

Right now, if you have whitespace at the end of a line, the config reader will include it as part of the value (string) and I think it shouldn't do that. An argument for changing the behavior is that this behavior is already inconsistent because you can't include whitespace at the beginning of a string.

@sethhall sethhall added this to the 3.1.0 milestone Oct 4, 2019
@0xxon 0xxon self-assigned this Oct 4, 2019
@0xxon 0xxon added the Area: Config label Oct 4, 2019
@JustinAzoff

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

Possibly relevant, a trailing comma also breaks sets:

Site::local_nets	192.168.0.0/16,10.0.0.0/8,172.16.0.0/16,

triggers

warning: bro.cfg/Input::READER_CONFIG: Could not convert line 'Site::local_nets	192.168.0.0/16,10.0.0.0/8,172.16.0.0/16,' to value. Ignoring line.
@jsiwek jsiwek added this to Unassigned / Todo in Release 3.1.0 via automation Oct 11, 2019
sethhall added a commit that referenced this issue Oct 14, 2019
This commit addresses issue #624
@sethhall

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2019

For reference, Justin moved his comment into a separate ticket: #636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 3.1.0
  
Unassigned / Todo
3 participants
You can’t perform that action at this time.