Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input framework does not raise Input::end_of_data and other events after 1st "Bad address:" errors #692

Open
mauropalumbo75 opened this issue Nov 20, 2019 · 0 comments

Comments

@mauropalumbo75
Copy link
Contributor

@mauropalumbo75 mauropalumbo75 commented Nov 20, 2019

I am writing a script to update zeek's local nets without restarting the program, using the input framework to load a file containing the local nets. It is also important that if something is wrong in this file, for example a bad ip address or a typo etc., this is handled gracefully, i.e. the error is reported and if the file is corrected this will be updated with the latest version.

A preliminary script I wrote is here:

localnetsupdate.zip

The networks.cfg file in it, contains a bad ip. The first time, everything goes as expected, i.e. I get a

Bad address: 1cfehjb00.0.0

error from the read_error event. If I subsequently correct the file with a correct ip, however, the events read_error and Input::end_of_data are not raised anymore. I expected such events to be raised for any further updates of this file, as it happens for other kind of errors.

I believe this happens somehow because the above error is detected in
threading/Formatter.cc, calling thread->Error(...)
instead of using FailWarn in the ascii reader.

@0xxon 0xxon added this to the 3.1.0 milestone Nov 21, 2019
@rsmmr rsmmr added this to Unassigned / Todo in Release 3.1.0 via automation Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 3.1.0
  
Unassigned / Todo
2 participants
You can’t perform that action at this time.