Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with Python 2 EOL #706

Open
jsiwek opened this issue Dec 11, 2019 · 4 comments
Open

Deal with Python 2 EOL #706

jsiwek opened this issue Dec 11, 2019 · 4 comments
Milestone

Comments

@jsiwek
Copy link
Member

@jsiwek jsiwek commented Dec 11, 2019

Since Python 2 EOL is January 1, 2020, I'd find it nice (but not critical) to address how we treat Python 2 support in the Zeek 3.1.0 release (similar timeframes). Dropping support in all Zeek-related projects is my preference. I didn't completely audit what needs to be done for that, but here's the tasks that come to mind:

  • Change invocations of python to python3 (e.g. in scripts/shebangs and in documentation)
  • Update documentation related to requirements/dependencies (e.g. READMEs) to state Python 3 is needed and also remove any Python2-specific instructions
  • Update CMake to enforce use of Python 3
  • Update any CI that's still testing against Python 2 (e.g. on Travis)
  • The above tasks will apply to most git submodules used by Zeek (and don't forget zkg)
@jsiwek jsiwek added this to the 3.1.0 milestone Dec 11, 2019
@jsiwek jsiwek added this to Unassigned / Todo in Release 3.1.0 via automation Dec 11, 2019
@jsiwek

This comment has been minimized.

Copy link
Member Author

@jsiwek jsiwek commented Dec 11, 2019

To clarify the reason for changing python usages to explicit python3, see https://www.python.org/dev/peps/pep-0394 -- distributions are recommended to keep python as meaning Python 2 and installing just Python 3 generally won't provide any binary named python.

@0xxon

This comment has been minimized.

Copy link
Member

@0xxon 0xxon commented Dec 11, 2019

From my point of view - I agree and we should just drop support for python 2.

@timwoj

This comment has been minimized.

Copy link
Contributor

@timwoj timwoj commented Dec 11, 2019

I agree. Python 2 is dead at this point and we should remove support for it.

@rsmmr

This comment has been minimized.

Copy link
Member

@rsmmr rsmmr commented Dec 12, 2019

Agree as well. And 3.1 is a good time for this our our end.

@rsmmr rsmmr modified the milestones: 3.1.0, 3.2.0 Jan 9, 2020
@rsmmr rsmmr added this to Unassigned / Todo in Release 3.2.0 via automation Jan 14, 2020
@rsmmr rsmmr removed this from Unassigned / Todo in Release 3.1.0 Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 3.2.0
  
Unassigned / Todo
4 participants
You can’t perform that action at this time.