New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Zeek's batching of Broker messages #771
Comments
Looks like we're running out of time here, so moving to 4.1.0. |
I think this is something to revisit once we have the new network protocol code landed in Broker. |
@rsmmr @Neverlord Have enough of the changes landed in Broker now to revisit this? |
I believe so. I believe I did some benchmarking for this (with and without batching), probably a good idea to revisit that now. |
I'll throw it in the 5.1 project. Hopefully we can get it closed out. |
Note that this comes with a risk of a major performance degradation in case that it doesn't quite work yet under heavy load. I would suggest we either do more testing first with the testing group before we merge, or we postpone for now in the spirit of not making large Broker changes this cycle. |
Ah yah, forgot about that. Taking it back out of the 5.1 project. We'll revisit it in 5.2. |
Initial investigations to remove Zeek-side batching were done in these PRs:
But findings indicate those changes may want to wait and re-evaluate after migrating to CAF 0.18 which aims to decrease cost of sending many smaller messages and avoid performance drop currently seen with these changes.
The text was updated successfully, but these errors were encountered: