Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to filter the fonts #18

Closed
mmrzk opened this issue Jan 29, 2020 · 3 comments
Closed

Possibility to filter the fonts #18

mmrzk opened this issue Jan 29, 2020 · 3 comments

Comments

@mmrzk
Copy link

mmrzk commented Jan 29, 2020

Hello there and thanks for the great lib!
I'd like to ask if there is any possibility to filter the fonts to have only those I'm interested in?
It would be nice if we could filter them by family, so that a method/function that filters them could have an array with strings such as
['family1', 'family2', 'family3']

@sconix
Copy link
Contributor

sconix commented Feb 8, 2020

That sounds like a good idea, I do not promise anything but will try to add such feature for 9.1.0. Until that PR's are welcome.

@mmrzk
Copy link
Author

mmrzk commented May 18, 2021

Hello again, it took me some time, I've submitted the PR #30

LukasKlement added a commit to LukasKlement/ngx-filtered-font-picker that referenced this issue Nov 11, 2022
@LukasKlement
Copy link

I've added a new PR to address this issue.

I'd argue the feature is important, specifically in cases where you are using this component to choose fonts for a document that is rendered server-side (e.g. a PDF). In that case, you may not want to give users all Google Fonts up for selection, but only a subset of fonts for which you have a server-side rendering licence and/or which are installed on your server.

sconix added a commit that referenced this issue Feb 26, 2023
#18 Possibility to filter the fonts
@sconix sconix closed this as completed Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants