Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search highlight background colour for accessibility #727

Merged
merged 2 commits into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@timothyis
Copy link
Member

commented Apr 10, 2019

This pull request changes the background colour of the highlighted search suggestion to be darker, increasing accessibility and usability.

A11y check: https://webaim.org/resources/contrastchecker/?fcolor=333333&bcolor=F1F1F1

@timothyis timothyis requested review from quietshu, evilrabbit and rdev Apr 10, 2019

@timothyis timothyis requested a review from msweeneydev as a code owner Apr 10, 2019

@now

This comment has been minimized.

Copy link

commented Apr 10, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://docs-git-fix-search-highlight-background.zeit.sh

@rdev

rdev approved these changes Apr 10, 2019

@timothyis timothyis merged commit 7fddac3 into master Apr 10, 2019

2 checks passed

now Deployment has completed
Details
now/package.json is ready

@timothyis timothyis deleted the fix/search-highlight-background branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.