New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command ctrl + C does not work #1121

Open
fabdelgado opened this Issue Dec 12, 2016 · 93 comments

Comments

Projects
None yet
@fabdelgado

fabdelgado commented Dec 12, 2016

The ctrl + c command to interrupt operations does not work.

@markpanado

This comment has been minimized.

markpanado commented Dec 12, 2016

I tested mine with the new update and it's working.

@mqudsi

This comment has been minimized.

Contributor

mqudsi commented Dec 12, 2016

It doesn't work for me, either. Ctrl+c is completely ignored running on Windows 10 build 1607 running cmd.exe (not bash.exe). In bash.exe, ctrl+c works, but the up arrow key does not work.

@willharrison

This comment has been minimized.

willharrison commented Dec 12, 2016

ctrl + c works for me. Having issues with ctrl+ r, up arrow, down arrow, and ctrl + backspace.

@warpdesign

This comment has been minimized.

warpdesign commented Dec 13, 2016

Here I cannot copy test to clipboard but ctrl+c to interrupt processes seems to work as expected.

When trying to copy selected text to the keyboard, the moment I press 'shift' or 'ctrl', the text I have selected gets unselected, so keeping shift+ctrl down and pressing c to paste does nothing as there's nothing left selected.

Not sure if it's related: but that's with a French keyboard layout.

@shern91

This comment has been minimized.

shern91 commented Dec 13, 2016

i also facing the same problem in copy text to clipboard, no matter i click Ctrl+C or Shift+Ctrl+C, once i click any of key those text will deselected.

P/S: Windows 10 64 bit user.

@curpin curpin referenced this issue Dec 13, 2016

Closed

Cannot do a copy for a selection #1175

1 of 2 tasks complete
@stereokai

This comment has been minimized.

stereokai commented Dec 13, 2016

All of the issues described so far are happening on my machine as well. Win10 64bit with Bash on Ubuntu on Windows.

@mqudsi

This comment has been minimized.

Contributor

mqudsi commented Dec 14, 2016

I just want to point out that ctrl+c works in a bash.exe shell, even though it does not work in the standard cmd.exe shell.

@stereokai

This comment has been minimized.

stereokai commented Dec 14, 2016

@mqudsi just to remove any shadow of doubt, it doesn't perform a copy, but cancels the current command (as it should)

@ppot

This comment has been minimized.

Collaborator

ppot commented Dec 15, 2016

@kvj

This comment has been minimized.

kvj commented Dec 15, 2016

The problem isn't only Ctrl+C alone, but any hotkeys bound to menu items under Linux and Windows. They're intercepted by Electron and not delivered to main window, I guess. For example, all my keybindings for tmux start from Ctrl+A and don't work in Hyper under Linux (instead, Select All is executed), but work well in macOS (Select All is Cmd+A there)

@liuyang1204

This comment has been minimized.

liuyang1204 commented Dec 15, 2016

@kvj +1

@mqudsi

This comment has been minimized.

Contributor

mqudsi commented Dec 15, 2016

@liuyang1204 there's a +1 button.

@kvj I'm not so sure about that. If that were the case, ctrl+c would not suddenly function if a bash.exe session is started under Windows.

@annnoo

This comment has been minimized.

annnoo commented Dec 15, 2016

Having quite the same problem in #1199 . I bound the "Close Session" shortcut to another key, but Ctrl+W is not working at all in vim.

@jamiewade

This comment has been minimized.

jamiewade commented Dec 20, 2016

Pressing Ctrl + C closes the window for me, but I want to use this keyboard command to stop processes running, for example Gulp.

Running Windows 10 64bit.

@SirTimmyTimbit

This comment has been minimized.

SirTimmyTimbit commented Dec 20, 2016

+1 on Windows 10,

@damien122

This comment has been minimized.

damien122 commented Dec 21, 2016

OS version and name: windows 10 x64

Hyper.app version: 1.0.0

I have also this problem

@JamieH

This comment has been minimized.

JamieH commented Dec 29, 2016

Still having this issue:

Hyper 1.0.0
Electron 1.4.7
win32 x64 10.0.14393

@halkeye

This comment has been minimized.

halkeye commented Dec 29, 2016

I don't think it's really worth people continuing to state they are still having the issue. There's a subscribe button on the right of this page so you can get notified of changes.

As I understand it the accelerator keys assigned to copy (and select all) in the menus are capturing the keys before they get to the app.

@sparebytes

This comment has been minimized.

sparebytes commented Jan 6, 2017

It appears VSCode has a similar issue so I'm just going to leave this here.
Microsoft/vscode#9347 (comment)

Something else I noticed is that the up and down keys work in PowerShell for going through history but it doesn't in the bash.exe shell even though ctrl+c works there.

@jq-87 jq-87 referenced this issue Oct 5, 2017

Closed

Search #2329

@Zeex

This comment has been minimized.

Zeex commented Nov 5, 2017

If I interrupt a process with Ctrl-C Hyper stops printing what I type, but output works just fine (Windows 10). Is it the same bug as this one?

@giggio

This comment has been minimized.

giggio commented Nov 6, 2017

I just tried the latest canary, which comes with xterm, and the problem persists. Here is how to test it: #1275 (comment)

@mikemaccana

This comment has been minimized.

mikemaccana commented Feb 16, 2018

Still happens on 2.0.0 canary 11

image

@mikemaccana

This comment has been minimized.

mikemaccana commented Feb 16, 2018

Linking to the win-pty issue:

rprichard/winpty#116

and the fix rprichard/winpty@c9ce3ad

Looks like 0.44 hasn't been released yet, when it does, and the other projects adopt it, as @stereokai says we'll have the fix.

@giggio

This comment has been minimized.

giggio commented Apr 18, 2018

I just tested the latest canary (18), and CTRL+C now breaks. It still does not work as expected in every scenario, but it breaks.
It still ouputs ^C on the screen if you type it on a open line, and it still does not copy, as it is expected on the normal Windows Prompt on Windows 10. And CTRL+V does not paste. It is better, but not there yet.

@cnoffsin

This comment has been minimized.

cnoffsin commented Apr 18, 2018

@giggio

This comment has been minimized.

giggio commented Apr 18, 2018

I can understand you not wanting it to copy, as I would expect the Hyper team to expect me to want it. I want it because this is the normal behavior on Windows now, and I use it like that when I am on plain cmd or posh. CTRL+SHIFT+C and CTRL+SHIFT+V are also coming to WSL (announced recently), so I expect that when it does, Hyper supports it. What it should do is work as expected. No surprises. And it should be configurable if I want it, so both @cnoffsin has his way, and I have mine.

@jukkalaurila

This comment has been minimized.

jukkalaurila commented Jun 4, 2018

I found that ctrl-h produces the character ^? (ASCII 127), the same as backspace. This makes it impossible to trigger any of the help functions in Emacs, since they start with ctrl-h. Do you consider this issue to be the same or do you want me to file this as a separate bug?

I'm using Hyper version 2.0.0 on Windows 10.

@chriskuech

This comment has been minimized.

chriskuech commented Jun 11, 2018

Is there any known workaround for cancelling a command in Windows until a fix for CTRL+C is pushed? I see scenarios where the only remediation I can find is to close the tab. Ex: when running PowerShell and cmdlet prompts for argument values.

@mrteye

This comment has been minimized.

mrteye commented Jun 12, 2018

Ctrl + C to stop execution of a script. This is still seriously lagging for me on Mac using Hyper ver: 2.0.0 (Stable)

Tested on Terminal.app and Hyper.app ssh'd into a remote Fedora machine:
cd / && find . -mtime -2 -ls

Results:
Terminal.app stops execution right after Ctrl + C key combo.
Hyper.app keeps running after multiple attempts and then finally breaks 30 seconds to a minute after.

I read lots of the comments above although I'm not sure what the current status of this issue is. Does anyone have an update, or more examples (if that helps.)

@sgarcia-dev

This comment has been minimized.

sgarcia-dev commented Jul 22, 2018

Is this not fixed yet? I'm on hyper 2.0.0 stable on Win 10 x64, and Hyper's editor break still doesn't work when using ctrl + c...

@albinekb

This comment has been minimized.

Contributor

albinekb commented Jul 23, 2018

It's shift+ctrl+c by default on windows @sgarcia-dev

@giggio

This comment has been minimized.

giggio commented Jul 24, 2018

It should be ctrl+c, which is the default.

@mikemaccana

This comment has been minimized.

mikemaccana commented Jul 25, 2018

This issue is about cancelling / interrupting (Ctrl C), not copying. Please report / discuss copying in another issue, as there's many people subscribed to this issue.

@eddyekofo94

This comment has been minimized.

eddyekofo94 commented Aug 14, 2018

Still not working guys, using Windows 10 WSL

@aminland

This comment has been minimized.

aminland commented Aug 14, 2018

still not working on 2.1.0 canary

@sieunhando

This comment has been minimized.

sieunhando commented Sep 16, 2018

Still not working now.

@mqudsi

This comment has been minimized.

Contributor

mqudsi commented Sep 16, 2018

There is no point in commenting to say it's not working. That's what the subscribe button is for, and until a developer actually cares about the problem and does something about it, it's going to continue not working because bugs don't randomly get fixed on their own.

It's very clear that cross-platform support is very low on the list of priorities for hyper developers. Anyone that actually cared about this has moved on from hyper a long time ago. There's no need for everyone to spam this issue with "new build came out today, still not working" because that accomplishes nothing.

@bgshacklett

This comment has been minimized.

bgshacklett commented Sep 17, 2018

For anyone who's really concerned about this, you may want to follow Microsoft/node-pty#216. It seems like the only way this is ever going to be fixed.

@giggio

This comment has been minimized.

giggio commented Sep 20, 2018

Yes, the ConPTY will change everything, but this is something that will only work on Windows 1809, that has not yet even come out (it should be out in the next weeks).
Even then, developers of terminal apps for Windows will have to create a ton of code to get it to work, and after it is done their app won't work on older Windows versions, which is a hard decision to make. Or even worse, support two different approaches. The good news is that Windows 10 versions are consolidating really fast. The bad news is that there are still a lot of users on Windows 7 and 8.

@bitcrazed

This comment has been minimized.

bitcrazed commented Sep 20, 2018

We hear ya @giggio and feel your pain. We wish that there was an easy solution here, but alas, there are a complex long-tail of issues preventing us from backporting the ConPTY API.

Do ping me if we can be of any help or if you find any issues, etc.: richturn at you know where .com!

@mikemaccana

This comment has been minimized.

mikemaccana commented Sep 21, 2018

FYI Windows folks: it's worth trying 'Terminus' https://github.com/Eugeny/terminus until this is fixed as Ctrl C works and it's quite similar (it's electron, uses CSS for styling etc) to Hyper!

@giggio

This comment has been minimized.

giggio commented Sep 21, 2018

@bitcrazed I am aware, I know this is a large effort, and I am happy it is finally happening! In time most of the terminal apps will have migrated, Windows 10 is more consolidated each day. Thank you and your team for your effort, you have been making our lives on Windows much much better.

@giggio

This comment has been minimized.

giggio commented Sep 21, 2018

@mikemaccana This Terminus looks cool! Trying it now!

@bitcrazed

This comment has been minimized.

bitcrazed commented Sep 21, 2018

@giggio No, thank YOU and the amazing community members who report issues and help us improve Windows and the Windows Console/Command-Line every day :) Exciting things ahead 😜 And of course, they Hyper devs and community who've built such a beautiful terminal 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment