New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux keyboard short-cuts need an overhaul. #1132

Closed
radicaled opened this Issue Dec 12, 2016 · 7 comments

Comments

Projects
None yet
7 participants
@radicaled

radicaled commented Dec 12, 2016

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Ubuntu 16.04
  • Hyper.app version: 1.0.0
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

Just checked out the 1.0.0 of Hyper. It looks cool, but basically most of the keyboard short-cuts for Linux have problems.

To start with, on Linux, terminal programs use a variety of combinations of CTRL+([a-z1-9]), so having those be menu accelerators is a problem. Terminals in Linux prefix all of the accelerators with "SHIFT" in order to get around this issue. CTRL+C (copy) becomes SHIFT+CTRL+C. The only exception for this appears to be "CTRL+0" which is used for resetting font size. Guess CTRL+0 is off limits for terminal applications for some reason, or just isn't used.

Also, tab navigation is broken in Ubuntu Linux: CTRL+ALT+(LEFT, RIGHT, UP, DOWN) is currently reserved for virtual desktop navigation. If you have virtual desktops enabled then that keystroke will take you to another desktop rather than switching tabs. I think Gnome Shell uses the same keybindings for virtual desktop navigation.

In general, on Linux, CTRL+PGUP and CTRL+PGDN are the keybindings for navigation between tabs.

There are a lot of little issues here and there on Github (ctrl+a doesn't work here, ctrl+x doesn't work there) so I thought it might be better to have a single issue detailing all of the broken accelerators rather than a ton of little ones.

I looked at accelerators.js, but it's currently doing a ternary check on whether the operating system is Mac or not. I'm actually not quite sure what the cleanest approach for OS detection (and behavior switching) is for that file, which is why this is more of a Github issue and less of a patch.

@maximumdata

This comment has been minimized.

Show comment
Hide comment
@maximumdata

maximumdata Dec 12, 2016

Agreed, I got quite a shock when I tried to ctrl+w to search for something in nano!

maximumdata commented Dec 12, 2016

Agreed, I got quite a shock when I tried to ctrl+w to search for something in nano!

@radicaled

This comment has been minimized.

Show comment
Hide comment
@radicaled

radicaled Dec 12, 2016

@CodeTheory I feel like this is a bug more than an enhancement -- some of the accelerators render Hyper unusable under Linux when it comes to certain programs.

radicaled commented Dec 12, 2016

@CodeTheory I feel like this is a bug more than an enhancement -- some of the accelerators render Hyper unusable under Linux when it comes to certain programs.

@timothyis

This comment has been minimized.

Show comment
Hide comment
@timothyis

timothyis Dec 12, 2016

Member

Good point @radicaled. Re-labeled 😄

Member

timothyis commented Dec 12, 2016

Good point @radicaled. Re-labeled 😄

@brbe

This comment has been minimized.

Show comment
Hide comment
@brbe

brbe Dec 12, 2016

ctrl-Z doesn't work as well. It seems that assumptions from OSX where Mod got mapped to CTRL.

brbe commented Dec 12, 2016

ctrl-Z doesn't work as well. It seems that assumptions from OSX where Mod got mapped to CTRL.

@WoodyWoodsta

This comment has been minimized.

Show comment
Hide comment
@WoodyWoodsta

WoodyWoodsta Dec 13, 2016

Possible dupe and additional discussion in #1069

WoodyWoodsta commented Dec 13, 2016

Possible dupe and additional discussion in #1069

@WoodyWoodsta WoodyWoodsta referenced this issue Dec 19, 2016

Closed

Can't exit to nano #1258

0 of 2 tasks complete

This was referenced Dec 20, 2016

@elchinot7

This comment has been minimized.

Show comment
Hide comment
@elchinot7

elchinot7 Mar 6, 2017

I been used CTRL-a as prefix for tmux, however in a Hyper terminal CTRL-a selects all text. This simple issue is stopping me from use Hyper as my every-day terminal app.

elchinot7 commented Mar 6, 2017

I been used CTRL-a as prefix for tmux, however in a Hyper terminal CTRL-a selects all text. This simple issue is stopping me from use Hyper as my every-day terminal app.

@ppot

This comment has been minimized.

Show comment
Hide comment
@ppot

ppot Aug 15, 2017

Collaborator

CLOSED IN #1876

Collaborator

ppot commented Aug 15, 2017

CLOSED IN #1876

@ppot ppot closed this Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment