New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor problem and Chinese character displayed incorrectly. #2124

Closed
QwQ11 opened this Issue Aug 29, 2017 · 6 comments

Comments

Projects
None yet
6 participants
@QwQ11

QwQ11 commented Aug 29, 2017

Using the WSL and oh-my-zsh.

  1. The cursor is not in the correct position.
    default
    I haven't type anything, but once you type a word, the cursor will back to right position, it is easy to see it before it is not where it should be. This problem also appears the last character you typed is a space.
    default

  2. Can not display Chinese character correctly, seems this problem still not being fixed.
    default
    what's worse, using the clear command.
    default

character: 你好


Hyper 1.3.3
Electron 1.4.16
win32 x64 10.0.15063

@chabou

This comment has been minimized.

Collaborator

chabou commented Sep 3, 2017

Can you try to reproduce with v1.4.3 ?

@LitoMore

This comment has been minimized.

LitoMore commented Sep 4, 2017

@chabou I can reproduce this bug with v1.4.3 .

Expected behavior

e-hyper

Actual behavior

a-hyper

How to reproduce this bug on macOS

Use Terminal.app or iTerm.app:

$ echo 你好 > sample

Then use Hyper.app:

$ cat sample
@lucasqueiroz

This comment has been minimized.

lucasqueiroz commented Sep 4, 2017

When pasting the character in the terminal, in 1.4.3, the bug also happens:
screen shot 2017-09-04 at 09 01 55

EDIT: I believe the red part is caused by a oh-my-zsh plugin

@chabou

This comment has been minimized.

Collaborator

chabou commented Sep 4, 2017

Will be fixed in 2.0.0 thanks to xterm
I tried your example on our xterm branch, and it works like a charm:
capture d ecran 2017-09-04 a 19 55 27

@chabou chabou added this to the 2.0.0 milestone Sep 4, 2017

@chabou chabou added Hterm bug and removed 🐛 Type: Bug labels Sep 4, 2017

@chabou chabou removed this from the 2.0.0 milestone Sep 4, 2017

@timothyis

This comment has been minimized.

Member

timothyis commented Apr 22, 2018

@QwQ11 Could you try this on the latest version of Hyper? I think your issue should be fixed! 🙏

@Stanzilla

This comment has been minimized.

Collaborator

Stanzilla commented Apr 23, 2018

Hey there, please try again with the new Hyper v2 release and open a new issue if the problem stills exists. Thank you!

@Stanzilla Stanzilla closed this Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment