Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font ligatures don't work v3 #3607

Open
orangecoloured opened this issue May 6, 2019 · 19 comments · Fixed by #3853

Comments

@orangecoloured
Copy link

@orangecoloured orangecoloured commented May 6, 2019

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: 10.14.4 macOS Mojave
  • Hyper.app version: 3.0.0
  • Link of a Gist with the contents of your .hyper.js:
  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla or with the hyper-font-ligatures add-on.

Issue

I'm using Fira Code font and the ligatures don't work. I found this issue #914 and tried installing the hyper-font-ligatures add-on or adding this css

termCSS: `
  x-screen x-row {
    font-variant-ligatures: initial;
  }
`,

but none of these seem to work.

@mhall

This comment has been minimized.

Copy link

@mhall mhall commented May 6, 2019

At least on Windows 10, setting webGLRenderer: false in your config file will bring them back (assuming you still have the hyper-font-ligatures plugin installed). This will also fix some of the other rendering anomalies of v3, although sadly not all.

@orangecoloured orangecoloured changed the title Font ligatures don't work Font ligatures don't work v3 May 6, 2019
@orangecoloured

This comment has been minimized.

Copy link
Author

@orangecoloured orangecoloured commented May 6, 2019

Oh. Yes, working now.
So, ligatures in exchange for performance :)

@nurtext

This comment has been minimized.

Copy link

@nurtext nurtext commented May 8, 2019

@orangecoloured So why did you close this bug?

@orangecoloured

This comment has been minimized.

Copy link
Author

@orangecoloured orangecoloured commented May 8, 2019

@nurtext Because technically this bug was resolved. The ligatures work without WebGL renderer.
I think another issue should be created addressing this.

@nurtext

This comment has been minimized.

Copy link

@nurtext nurtext commented May 8, 2019

@orangecoloured I understand, but for me it's still open because turning off the newly introduced renderer isn't a valid fix. Ever tried tailing or cating some logs with the old renderer? It made Hyper almost useless for me. Now Hyper is back in the game (at least for me), but ligatures are a must have in 2019 IMHO.

@mhall

This comment has been minimized.

Copy link

@mhall mhall commented May 8, 2019

Yeah, I would recommend reopening this as well.

@depadiernos

This comment has been minimized.

Copy link

@depadiernos depadiernos commented Aug 5, 2019

So, based on this comment, looks like there's a fix for this in xterm.js. Would be really awesome to get that pulled in so ligatures will work without a performance hit.

@GitSquared

This comment has been minimized.

Copy link
Contributor

@GitSquared GitSquared commented Sep 17, 2019

xTerm 4 supports this through the new Addon system: https://github.com/xtermjs/xterm-addon-ligatures

However, the xterm fork used by Hyper is severely out of date: 56 commits ahead, 1290 commits behind.

Edit: Switching the fork for latest xTerm works... except the WebGL renderer is quite broken - I believe it should be possible to fix it but I haven't researched that much. Also, the fork contains valuable work that needs to be rebased on xterm@4.

@nurtext

This comment has been minimized.

Copy link

@nurtext nurtext commented Sep 27, 2019

@GitSquared Looks like they're already on it: #3830

@Stanzilla

This comment has been minimized.

Copy link
Collaborator

@Stanzilla Stanzilla commented Sep 27, 2019

@GitSquared our effort in that PR is currently stuck on broken resizing

@GitSquared

This comment has been minimized.

Copy link
Contributor

@GitSquared GitSquared commented Oct 9, 2019

Now that #3830 has been merged, I'm sending a PR for enabling font ligatures.

@alexgalkin1994

This comment has been minimized.

Copy link

@alexgalkin1994 alexgalkin1994 commented Oct 11, 2019

Does not work for me, even with WebGL disabled.

@GitSquared

This comment has been minimized.

Copy link
Contributor

@GitSquared GitSquared commented Oct 11, 2019

@alexgalkin1994 You're testing on the canary version, right?

@Stanzilla Stanzilla reopened this Oct 12, 2019
@Stanzilla

This comment has been minimized.

Copy link
Collaborator

@Stanzilla Stanzilla commented Oct 12, 2019

Reopening since I don't see them working as well here, something broke during the Electron update?

@GitSquared

This comment has been minimized.

Copy link
Contributor

@GitSquared GitSquared commented Oct 12, 2019

@Stanzilla They still work for me under Linux, could this be platform-specific? (Still using Fira Code.)

Screenshot_20191012_170136

@Stanzilla

This comment has been minimized.

Copy link
Collaborator

@Stanzilla Stanzilla commented Oct 12, 2019

Could be yea, anything known about issues with that on Windows @Tyriar?

@Stanzilla Stanzilla pinned this issue Oct 12, 2019
@LabhanshAgrawal

This comment has been minimized.

Copy link
Contributor

@LabhanshAgrawal LabhanshAgrawal commented Oct 12, 2019

Working for me on mac (also using Fira Code)

@alexgalkin1994

This comment has been minimized.

Copy link

@alexgalkin1994 alexgalkin1994 commented Oct 13, 2019

@alexgalkin1994 You're testing on the canary version, right?

I installed it via Homebrew. (brew cask install hyper)
Version 3.0.2 is installed

@GitSquared

This comment has been minimized.

Copy link
Contributor

@GitSquared GitSquared commented Oct 14, 2019

@alexgalkin1994 That's the latest release. This issue has been closed on the canary branch, which is the development version - ligatures will be enabled in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.