Try to cd into non-existent directory with period/dot in name crashes Hyperterm #594

Open
DaveFlynn opened this Issue Aug 9, 2016 · 6 comments

Projects

None yet

6 participants

@DaveFlynn

To reproduce:

$ cd foo.bar

If the directory foo.bar does not exist, the app will crash.

@dj-hedgehog

Can't reproduce. Works as expected for me:

cd foo.bar                                                                                                                                                    
cd: no such file or directory: foo.bar

Does it matter where you execute the command?

@DaveFlynn

Nope. Could be anywhere. Happens when I am SSH'd into a remote server, or local.

Here's a video of it crashing:

https://dl.dropboxusercontent.com/u/1437623/hyper.mov

Version 0.7.1 (0.7.1.36)

@ppot
Collaborator
ppot commented Aug 9, 2016

@DaveFlynn @dj-hedgehog I tested the behavior and it result into BASH problem only.
I tested the call cd foo.bar and Hyperterm crashed. However on ZSH it does the expected behavior.

cd foo.bar
cd: no such file or directory: foo.bar

@dj-hedgehog

It would be awesome if any of you would checkout the source code, npm i && npm run start, replicate the problem and tell us if the log shows anything useful.

@MrRio
Collaborator
MrRio commented Aug 9, 2016 edited

'foo.bar' appears to be matching isUrlCommand and triggering
a SESSION_URL_SET. I think we should maybe consider moving this
functionality to a plugin? CC @rauchg

@rauchg
Contributor
rauchg commented Dec 31, 2016

URL handling has been vastly improved on 1.0.1! Thanks for the reports 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment