馃檶 unicode/emoji fix #1018

Merged
merged 1 commit into from Dec 7, 2016

Projects

None yet

5 participants

@dotcypress
Contributor
dotcypress commented Nov 19, 2016 edited

Emoji fix.

Related PR: #740

Before:
screen shot 2016-11-19 at 2 47 39 am

After:
screen shot 2016-11-19 at 2 48 27 am

@dotcypress dotcypress unicode fix
87fee8e
@matheuss
Collaborator

Amazing, @dotcypress 馃槍

We still need to fix the insertion, removal, and the behavior of more complex emojis:

kapture 2016-11-19 at 10 15 43

cc @rauchg @rginda

@CodeTheory

From most of the issues we've had with emojis, it looks like the problems are with the initial rendering of emoji. So this PR is 馃憤 from me!

@alucard0134

good start on crushing the emoji issue 馃憤

@rauchg
Contributor
rauchg commented Nov 21, 2016

@dotcypress this is amazing stuff

@matheuss
Collaborator

So, @dotcypress: I think the last thing we should do before merging is finding a way to add line-height: 1em to <x-row> if there's any emoji on the screen.
This is not the best solution in the world, but I think it's enough until we manage to fix line-height on hterm 馃憣

@matheuss
Collaborator
matheuss commented Dec 7, 2016

Ping @dotcypress @rauchg: should we merge as it is?

@rauchg rauchg merged commit aa41081 into zeit:master Dec 7, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rauchg
Contributor
rauchg commented Dec 7, 2016

Yes. I'd love to fix the other issue (maybe @dotcypress has good ideas), but for now this is an improvement

@dotcypress dotcypress deleted the dotcypress:unicode-fix branch Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment