Related PR: #740
Amazing, @dotcypress 😌
We still need to fix the insertion, removal, and the behavior of more complex emojis:
cc @rauchg @rginda
From most of the issues we've had with emojis, it looks like the problems are with the initial rendering of emoji. So this PR is 👍 from me!
good start on crushing the emoji issue 👍
@dotcypress this is amazing stuff
So, @dotcypress: I think the last thing we should do before merging is finding a way to add line-height: 1em to <x-row> if there's any emoji on the screen.
This is not the best solution in the world, but I think it's enough until we manage to fix line-height on hterm 👌
Ping @dotcypress @rauchg: should we merge as it is?
Yes. I'd love to fix the other issue (maybe @dotcypress has good ideas), but for now this is an improvement