Fix keyboard shortcuts on Linux and Windows #1058

merged 10 commits into from Nov 30, 2016


None yet

7 participants


This PR introduces a temporary fix for the issue with keyboard shortcuts (accelerators) on Windows and Linux.

The fix consists of a check on every keyDown event: if such event is a Hyper accelerator (Ctrl+tab, for example), we prevent hterm from consuming it. With that, our code (or Electron's code, depending on the accelerator) can consume it.

This is a temporary fix because in the near future we'll probably have a way to customize the accelerators via .hyper.js.

Closes #274; Closes #1025;

matheuss added some commits Nov 29, 2016
@matheuss matheuss `command` => `mod` bd24fe6
@matheuss matheuss `Option` => `Alt` f78d4a1
@matheuss matheuss Allow hterm to consume a keyboard event only if it's not a Hyper acce…
@matheuss matheuss Remove `console.log`s 5678954
@matheuss matheuss Say no to bikeshedding 8229b5f
@matheuss matheuss We already clear the selection on `onKeyDown` 0e16546
@matheuss matheuss Add comments bacfb8c
@matheuss matheuss Remove meaningless comment a6c9543
@matheuss matheuss Add fullscreen shortcut for Windows and Linux 1576d5a
@matheuss matheuss Use the accelerators defined in `accelerators.js` for the app menu
@matheuss matheuss added this to the v1.0.0 milestone Nov 30, 2016
@rauchg rauchg merged commit be286c0 into master Nov 30, 2016

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
continuous-integration/travis-ci/push The Travis CI build is in progress
continuous-integration/appveyor/branch AppVeyor build succeeded
continuous-integration/appveyor/pr AppVeyor build succeeded
@rauchg rauchg deleted the fix/keyboard-shortcuts branch Nov 30, 2016


@matheuss matheuss added a commit that referenced this pull request Dec 2, 2016
@matheuss matheuss Fix a regression introduced by #1058
Such regression broke the character composition/paste on macOS

When will it be in a release? It's a key feature. >.>

leo commented Dec 3, 2016

@roccomuso Comes with the next release

jekku commented Dec 15, 2016

still not working with archlinux-kde

rickmed commented Dec 24, 2016 edited

was this added to 1.0? is not working in my xubuntu 16.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment