Fix text deselect #1218

Merged
merged 1 commit into from Dec 15, 2016

Projects

None yet

4 participants

@ppot
Collaborator
ppot commented Dec 15, 2016 edited

Close #819

@ppot ppot Fix key focus
c82cd3a
@ppot
Collaborator
ppot commented Dec 15, 2016

I can't review myself. @matheuss @albinekb @rauchg

@ppot ppot referenced this pull request Dec 15, 2016
Open

locale error on new shell #1206

2 of 2 tasks complete
@albinekb

Havn't tested this myself, but the code looks 🆗

@ppot ppot merged commit 4943e4a into zeit:master Dec 15, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ppot ppot deleted the ppot:pref_unselect branch Dec 15, 2016
@naturalethic
naturalethic commented Dec 20, 2016 edited

This is still not fixed on MacOS at least. First of all, e.code is ShiftLeft, ControlLeft, etc. But even if I hack it to check these, and ensure that selection.clear is not being called, the selection is still being cleared by something else.

In case anyone is interested I changed the test to:
if (!/^(Shift|Control|CapsLock)/.test(e.code) && e.key !== 'Dead') {

@ppot
Collaborator
ppot commented Dec 20, 2016

On MacOS this work perfectly. This is not released yet. If you still have a problem. feel free to make a gif. With your specific use case.

@naturalethic

I was hacking on it in dev mode using the repo master branch. A production build to dist doesn't work for me, it won't open a new window. Anyhoo, I'm fine waiting for the next official release. Thanks again.

@@ -213,20 +213,22 @@ hterm.Keyboard.prototype.onKeyDown_ = function (e) {
if (e.altKey || e.metaKey || isAccelerator(e)) {
// hterm shouldn't consume a hyper accelerator
+ // // Was the hyperCaret removed for selectAll
+ if (e.key === 'v' && !this.terminal.cursorNode_.contains(this.hyperCaret)) {
@matheuss
matheuss Jan 2, 2017 Collaborator

@ppot why this is here? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment