Fix ctrl+c to close WebView 馃嵕 #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchg
reviewed
Dec 21, 2016
|
|
||
| handleKeyDown(e) { | ||
| if (e.ctrlKey && e.key === 'c') { | ||
| this.props.onURLAbort(); |
There was a problem hiding this comment.
shouldn't we check here that there's an actual URL open?
There was a problem hiding this comment.
We could. But it's enabled only if there is one oppened.
Closed
Closed
tylerong
pushed a commit
to tylerong/hyper
that referenced
this pull request
Jul 3, 2017
* rm hyperCaretFocus => prevent callstask * keep caret component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Keybinding
Keep caretComponent To prevent doom error.
close #392