Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the lang env by using os-locale #2913

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
4 participants
@Stanzilla
Copy link
Collaborator

commented Apr 23, 2018

This is #605 rebased and @leo's comment addressed.

I tested that it still works correctly on en_US

@albinekb
Copy link
Contributor

left a comment

I think this is ready to merge, we had LGTM in the old PR, same code just the dep added.

@Stanzilla Stanzilla requested a review from chabou Apr 24, 2018

@chabou

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2018

Works great
Before:
image

After:
image

@chabou

chabou approved these changes Apr 27, 2018

@chabou chabou merged commit 9a53672 into zeit:canary Apr 27, 2018

4 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Stanzilla Stanzilla deleted the Stanzilla:605_rebase branch Apr 27, 2018

@chabou chabou referenced this pull request May 18, 2018

Closed

locale error on new shell #1206

2 of 2 tasks complete

@chabou chabou referenced this pull request Jun 17, 2018

Closed

[v2] CJK languages not working #2322

2 of 2 tasks complete

@timomeh timomeh referenced this pull request Jun 18, 2018

Closed

"Setting locale failed" after update to 2.1.0-canary.2 #3091

2 of 2 tasks complete

chabou added a commit that referenced this pull request Dec 15, 2018

@pi0

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2018

This is causing warns when my locale is not en_US:

MacOS Mojave 10.14.2 (18C54) / Hyper 2.1.0 stable

image

perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LC_ALL = (unset),
        LC_CTYPE = "en_IR.UTF-8",
        LANG = "en_IR.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LC_ALL = (unset),
        LC_CTYPE = "en_IR.UTF-8",
        LANG = "en_IR.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").

The current workaround is manually set env in ~/.hyper.js:

{
    env: {
     LANGUAGE: 'en_US.UTF-8',
     LC_ALL: 'en_US.UTF-8',
     LANG: 'en_US.UTF-8',
     LC_TYPE: 'en_US.UTF-8',
    },
}
@pi0

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2018

More investigations: os-locale will use defaults read -g AppleLocale command to compute locale which resolves to en_IR which is an invalid (at least perl) locale. We may need a validation mecanism over it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.