Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade electron to v3 #3420

Merged
merged 3 commits into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@juancampa
Copy link
Collaborator

commented Jan 17, 2019

Problem

Electron v4 has a big performance issue with 2d canvases Tracked here:

electron/electron#16439

Solution

Revert back to Electron v3 for now.

Testing

  • No errors on output
  • Plugins work (tested installing and using hypercwd)
  • Multiple tabs
  • Multiple windows
  • Splits
  • Menus
  • Auto update (pop up shows)
  • Clean shutdown
  • Vim session with splits
  • Clipboard works
    • Through menu
    • Hotkeys
  • Performance looks fine
    • canvas
    • webgl

  • Linux
  • MacOS
  • Windows
Reverting back to electron v3
Electron v4 has a big performance issue with 2d canvases Tracked here:

 electron/electron#16439

@juancampa juancampa requested review from chabou and Stanzilla Jan 17, 2019

@Stanzilla
Copy link
Collaborator

left a comment

LGTM, tested on Windows.

@chabou
Copy link
Collaborator

left a comment

Can you commit your yarn.lock?

@juancampa

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 18, 2019

Can you commit your yarn.lock?

Thanks, I guess I also missed the last yarn.lock. Not sure why I keep doing this 😅

@chabou

chabou approved these changes Jan 18, 2019

@chabou chabou merged commit ee8e95b into zeit:canary Jan 18, 2019

4 checks passed

ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.