Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Remove next/asset as it's undocumented #5970

Closed
timneutkens opened this issue Dec 31, 2018 · 0 comments · Fixed by #6046
Closed

[RFC] Remove next/asset as it's undocumented #5970

timneutkens opened this issue Dec 31, 2018 · 0 comments · Fixed by #6046

Comments

@timneutkens
Copy link
Member

Feature request

Is your feature request related to a problem? Please describe.

Currently there is a next/asset module that isn't in use anywhere. It's main purpose is to prefix /static with the assetPrefix, it only works for /static, so it doesn't really expose the assetPrefix for usage.

Describe the solution you'd like

Removes this module to reduce API surface. It's currently being bundled even when not used because we have to instantiate the module.

Describe alternatives you've considered

I currently don't see a valid use-case for this API. I'm pretty confident we can remove it, it was never documented in the readme, it's not in use in zeit.co / nextjs.org and I reached out to a few users to see if they used it, which was not the case, because it was never documented and doesn't serve a wealth of use cases.

@timneutkens timneutkens changed the title [RFC] Remove next/asset as it's undocumented / not really useful [RFC] Remove next/asset as it's undocumented Dec 31, 2018
timneutkens added a commit that referenced this issue Jan 14, 2019
* Remove next/asset

Reasoning described in #5970

* Remove next/asset tests

* Bring back asset-page
@lock lock bot locked as resolved and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant