Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with-firebase-auth example #5742

Merged
merged 4 commits into from Nov 25, 2018
Merged

Conversation

obedparla
Copy link
Contributor

  • The with-firebase-auth example won't run unless a database with proper rules is created first.
  • Add a small error callback to addDbListener to help with debugging if someone's database connection doesn't work.

The example won't run unless a database with proper rules is created first. 
The code in the example doesn't give any hints of this either and it fails silently (there is no error handling).
Makes it easier to debug if something is wrong with it.
@timneutkens
Copy link
Member

Could you fix the linting error? Then I'll merge it 👍

Co-Authored-By: obedparla <obed.marquezp@gmail.com>
@obedparla
Copy link
Contributor Author

Done!

@timneutkens timneutkens merged commit b63487c into vercel:canary Nov 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants