Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling for error being thrown in _app getinitialProps #6680

Merged
merged 7 commits into from Mar 17, 2019
Merged

Add error handling for error being thrown in _app getinitialProps #6680

merged 7 commits into from Mar 17, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 16, 2019 •
edited

When an error is thrown in pages/_app.js's getInitialProps we currently show internal server error this adds handling to show the error that was thrown when in dev mode.

I also added git reset --hard HEAD before retrying tests to clean up any left over changes from the last run.

Fixes: #5400

@ijjk
Add error handling for error being
305fed8 
thrown in _app getinitialProps
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 12s 12.6s ⚠️ +5.61%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.34 kB 3.34 kB ✓
Client pages/link gzip Size 1.51 kB 1.51 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.2 kB 1.2 kB ✓
Build Dir Size 457 kB 457 kB ✓
Average Memory Usage 129 MB 132 MB ⚠️ +2.68%
Max Memory Usage 176 MB 173 MB -1.27%
Average CPU Usage 97.46% 93.4% -4.17%
Max CPU Usage 111.11% 122.22% ⚠️ +10%
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%
Click to expand serverless stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 16.8s 16.5s -1.65%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.34 kB 3.34 kB ✓
Client pages/link gzip Size 1.51 kB 1.51 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 261 kB 261 kB ⚠️ +0.03%
Serverless pages/link gzip Size 62.1 kB 62.1 kB ⚠️ +0.05%
Serverless pages/index Size 256 kB 256 kB ⚠️ +0.03%
Serverless pages/index gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/_error Size 258 kB 258 kB ⚠️ +0.03%
Serverless pages/_error gzip Size 60.9 kB 60.9 kB ⚠️ +0.04%
Serverless pages/routerDirect Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/routerDirect gzip Size 60.9 kB 60.9 kB ⚠️ +0.04%
Serverless pages/withRouter Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/withRouter gzip Size 61 kB 61 kB ⚠️ +0.04%
Build Dir Size 1.56 MB 1.56 MB ⚠️ +0.02%
Average Memory Usage 144 MB 145 MB ⚠️ +0.6%
Max Memory Usage 191 MB 194 MB ⚠️ +1.47%
Average CPU Usage 94.92% 95.04% ⚠️ +0.13%
Max CPU Usage 110% 111.11% ⚠️ +1.01%
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%

@ijjk
Fix handling of of undefined being thrown
a4d4bb7 
in getInitialProps and update integration test
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 11.3s 11.2s -1.08%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.34 kB 3.34 kB ✓
Client pages/link gzip Size 1.51 kB 1.51 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.2 kB 1.2 kB ✓
Build Dir Size 457 kB 457 kB ✓
Average Memory Usage 129 MB 129 MB -0.07%
Max Memory Usage 173 MB 175 MB ⚠️ +0.94%
Average CPU Usage 97.4% 97.86% ⚠️ +0.47%
Max CPU Usage 111.11% 122.22% ⚠️ +10%
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%
Click to expand serverless stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 15.6s 15.7s ⚠️ +0.65%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.34 kB 3.34 kB ✓
Client pages/link gzip Size 1.51 kB 1.51 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 261 kB 262 kB ⚠️ +0.03%
Serverless pages/link gzip Size 62.1 kB 62.1 kB ⚠️ +0.05%
Serverless pages/index Size 256 kB 256 kB ⚠️ +0.03%
Serverless pages/index gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/_error Size 258 kB 258 kB ⚠️ +0.03%
Serverless pages/_error gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/routerDirect Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/routerDirect gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/withRouter Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/withRouter gzip Size 61 kB 61 kB ⚠️ +0.05%
Build Dir Size 1.56 MB 1.56 MB ⚠️ +0.03%
Average Memory Usage 146 MB 146 MB -0.19%
Max Memory Usage 195 MB 194 MB -0.37%
Average CPU Usage 94.26% 94.97% ⚠️ +0.75%
Max CPU Usage 111.11% 122.22% ⚠️ +10%
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 12.4s 11.7s -5.43%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.34 kB 3.34 kB ✓
Client pages/link gzip Size 1.51 kB 1.51 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.2 kB 1.2 kB ✓
Build Dir Size 457 kB 457 kB ✓
Average Memory Usage 128 MB 131 MB ⚠️ +2.41%
Max Memory Usage 167 MB 174 MB ⚠️ +4.59%
Average CPU Usage 93.25% 96.94% ⚠️ +3.96%
Max CPU Usage 111.11% 111.11% ✓
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%
Click to expand serverless stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 16.4s 17.5s ⚠️ +7.19%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.34 kB 3.34 kB ✓
Client pages/link gzip Size 1.51 kB 1.51 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 261 kB 262 kB ⚠️ +0.03%
Serverless pages/link gzip Size 62.1 kB 62.1 kB ⚠️ +0.05%
Serverless pages/index Size 256 kB 256 kB ⚠️ +0.03%
Serverless pages/index gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/_error Size 258 kB 258 kB ⚠️ +0.03%
Serverless pages/_error gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/routerDirect Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/routerDirect gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/withRouter Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/withRouter gzip Size 61 kB 61 kB ⚠️ +0.05%
Build Dir Size 1.56 MB 1.56 MB ⚠️ +0.03%
Average Memory Usage 141 MB 146 MB ⚠️ +4.18%
Max Memory Usage 209 MB 195 MB -6.57%
Average CPU Usage 95.11% 95.61% ⚠️ +0.53%
Max CPU Usage 122.22% 111.11% -9.09%
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 12.7s 12.6s -0.44%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.31 kB 3.31 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.2 kB 1.2 kB ✓
Build Dir Size 457 kB 457 kB ✓
Average Memory Usage 129 MB 129 MB -0.17%
Max Memory Usage 168 MB 169 MB ⚠️ +0.44%
Average CPU Usage 93.58% 93.86% ⚠️ +0.3%
Max CPU Usage 111.11% 111.11% ✓
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%
Click to expand serverless stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 17s 16.7s -1.44%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.31 kB 3.31 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 261 kB 261 kB ⚠️ +0.03%
Serverless pages/link gzip Size 62.1 kB 62.1 kB ⚠️ +0.05%
Serverless pages/index Size 256 kB 256 kB ⚠️ +0.03%
Serverless pages/index gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/_error Size 258 kB 258 kB ⚠️ +0.03%
Serverless pages/_error gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/routerDirect Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/routerDirect gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/withRouter Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/withRouter gzip Size 61 kB 61 kB ⚠️ +0.05%
Build Dir Size 1.56 MB 1.56 MB ⚠️ +0.03%
Average Memory Usage 145 MB 144 MB -0.4%
Max Memory Usage 193 MB 192 MB -0.07%
Average CPU Usage 95.08% 94.44% -0.67%
Max CPU Usage 111.11% 111.11% ✓
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 12.5s 12.5s -0.11%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.31 kB 3.31 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Base Rendered Size 1.2 kB 1.2 kB ✓
Build Dir Size 457 kB 457 kB ✓
Average Memory Usage 131 MB 128 MB -1.9%
Max Memory Usage 176 MB 167 MB -5.3%
Average CPU Usage 93.69% 94.38% ⚠️ +0.74%
Max CPU Usage 122.22% 110% -10%
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%
Click to expand serverless stats
zeit/next.js canary ijjk/next.js app-gip-error-handling Change
Build Duration 17s 16.7s -1.5%
Client _app Size 3.03 kB 3.03 kB ✓
Client _app gzip Size 1.29 kB 1.29 kB ✓
Client _error Size 7.91 kB 7.91 kB ✓
Client _error gzip Size 3.17 kB 3.17 kB ✓
Client pages/index Size 298 B 298 B ✓
Client pages/index gzip Size 235 B 235 B ✓
Client pages/link Size 3.31 kB 3.31 kB ✓
Client pages/link gzip Size 1.5 kB 1.5 kB ✓
Client pages/routerDirect Size 426 B 426 B ✓
Client pages/routerDirect gzip Size 305 B 305 B ✓
Client pages/withRouter Size 408 B 408 B ✓
Client pages/withRouter gzip Size 294 B 294 B ✓
Client main Size 21.9 kB 21.9 kB ✓
Client main gzip Size 7.28 kB 7.28 kB ✓
Client commons Size 186 kB 186 kB ✓
Client commons gzip Size 60.4 kB 60.4 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 774 B 774 B ✓
Serverless pages/link Size 261 kB 261 kB ⚠️ +0.03%
Serverless pages/link gzip Size 62.1 kB 62.1 kB ⚠️ +0.05%
Serverless pages/index Size 256 kB 256 kB ⚠️ +0.03%
Serverless pages/index gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/_error Size 258 kB 258 kB ⚠️ +0.03%
Serverless pages/_error gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/routerDirect Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/routerDirect gzip Size 60.9 kB 60.9 kB ⚠️ +0.05%
Serverless pages/withRouter Size 257 kB 257 kB ⚠️ +0.03%
Serverless pages/withRouter gzip Size 61 kB 61 kB ⚠️ +0.05%
Build Dir Size 1.56 MB 1.56 MB ⚠️ +0.03%
Average Memory Usage 145 MB 144 MB -0.87%
Max Memory Usage 192 MB 229 MB ⚠️ +19.4%
Average CPU Usage 95.36% 95.47% ⚠️ +0.12%
Max CPU Usage 111.11% 111.11% ✓
node_modules Size 42.8 MB 42.8 MB ⚠️ +0%

@ijjk ijjk merged commit 87bd1c3 into vercel:canary Mar 17, 2019
@ijjk ijjk deleted the app-gip-error-handling branch March 17, 2019 16:43
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@dav-is dav-is dav-is approved these changes

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in getInitialProps handles differently in _app.js compared to other pages
3 participants
@ijjk @timneutkens @dav-is