Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript compilation #7110

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
1 participant
@timneutkens
Copy link
Member

commented Apr 23, 2019

Fixes #7111

  • Compile .ts and .tsx files using @babel/preset-typescript
  • Doesn't do type checking yet
  • Adds tests for functioning HMR and rendering

@timneutkens timneutkens requested review from dav-is, ijjk, lfades and Timer as code owners Apr 23, 2019

@github-actions

This comment has been minimized.

Copy link

commented Apr 23, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/ts Change
Build Duration 12.2s 12.1s -118ms
node_modules Size 39.8 MB 39.8 MB ⚠️ +26.8 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB
Client _app Size 2.2 kB 2.2 kB
Client _app gzip Size 942 B 942 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.41 kB 5.41 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.59 kB 3.59 kB
Client pages/link gzip Size 1.62 kB 1.62 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 28 kB 28 kB
Client main gzip Size 9.66 kB 9.66 kB
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.3 kB 57.3 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 616 kB 616 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/ts Change
Build Duration 14s 14.6s ⚠️ +606ms
node_modules Size 39.8 MB 39.8 MB ⚠️ +26.8 kB
Total Bundle (main, webpack, commons) Size 207 kB 207 kB
Total Bundle (main, webpack, commons) gzip Size 68.2 kB 68.2 kB
Client _app Size 2.2 kB 2.2 kB
Client _app gzip Size 942 B 942 B
Client _error Size 14.2 kB 14.2 kB
Client _error gzip Size 5.41 kB 5.41 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.59 kB 3.59 kB
Client pages/link gzip Size 1.62 kB 1.62 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 28 kB 28 kB
Client main gzip Size 9.66 kB 9.66 kB
Client commons Size 177 kB 177 kB
Client commons gzip Size 57.3 kB 57.3 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 326 kB 326 kB
Serverless pages/link gzip Size 87.2 kB 87.2 kB -1 B
Serverless pages/index Size 320 kB 320 kB
Serverless pages/index gzip Size 85.3 kB 85.3 kB -2 B
Serverless pages/_error Size 321 kB 321 kB
Serverless pages/_error gzip Size 85 kB 85 kB -1 B
Serverless pages/routerDirect Size 320 kB 320 kB
Serverless pages/routerDirect gzip Size 85.4 kB 85.4 kB -3 B
Serverless pages/withRouter Size 320 kB 320 kB
Serverless pages/withRouter gzip Size 85.4 kB 85.4 kB -2 B
Build Dir Size 2.19 MB 2.19 MB

@timneutkens timneutkens added this to In progress in TypeScript via automation Apr 23, 2019

@timneutkens timneutkens changed the title [WIP] Add Typescript compilation Add Typescript compilation Apr 23, 2019

@timneutkens timneutkens merged commit c795583 into zeit:canary Apr 23, 2019

4 of 5 checks passed

coverage/coveralls Coverage decreased (-6.9%) to 49.68%
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zeit.next.js #20190423.9 succeeded
Details

TypeScript automation moved this from In progress to Done Apr 23, 2019

@timneutkens timneutkens deleted the timneutkens:add/ts branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.