Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated with-redux-thunk example using useSelector and useDispatch #8396

Merged
merged 6 commits into from Aug 16, 2019
Merged

Updated with-redux-thunk example using useSelector and useDispatch #8396

merged 6 commits into from Aug 16, 2019

Conversation

matamatanot
Copy link
Contributor

・Update libraries
・Use new React-Redux API useSelector and useDispatch in components/***.js

I tried to convert Class Componetpages/index.js to Functional Component. I cannot.
But, it is helpful to use both connect() and new APIs.

@ijjk
Copy link
Member

ijjk commented Aug 16, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
buildDuration 24.3s 23.8s -490ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.56 kB 6.56 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 190 kB 190 kB ✓
commons.HASH.js gzip 61.6 kB 61.6 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.module.js 16.2 kB 16.2 kB ✓
main-HASH.module.js gzip 6.28 kB 6.28 kB -1 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 171 kB 171 kB ✓
commons.HASH.module.js gzip 55.4 kB 55.4 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 1.06 kB 1.06 kB ✓
hooks.js gzip 600 B 601 B ⚠️ +1 B
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.13 kB 8.13 kB ✓
link.js gzip 3.49 kB 3.49 kB -1 B
routerDirect.js 429 B 429 B ✓
routerDirect.js gzip 292 B 292 B ✓
withRouter.js 439 B 439 B ✓
withRouter.js gzip 290 B 289 B -1 B
Overall change ✓
Client Pages Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 10.6 kB 10.6 kB ✓
_error.module.js gzip 4.31 kB 4.31 kB ✓
hooks.module.js 596 B 596 B ✓
hooks.module.js gzip 354 B 354 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.67 kB 3.67 kB ✓
routerDirect.module.js 417 B 417 B ✓
routerDirect.module.js gzip 292 B 292 B ✓
withRouter.module.js 427 B 427 B ✓
withRouter.module.js gzip 291 B 291 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
link 2.8 kB 2.8 kB ✓
link gzip 850 B 851 B ⚠️ +1 B
index 2.75 kB 2.75 kB ✓
index gzip 843 B 840 B -3 B
withRouter 2.81 kB 2.81 kB ✓
withRouter gzip 838 B 839 B ⚠️ +1 B
Overall change ✓
Serverless Mode
General
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
buildDuration 25.4s 25.3s -56ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.56 kB 6.56 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 190 kB 190 kB ✓
commons.HASH.js gzip 61.6 kB 61.6 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.module.js 16.2 kB 16.2 kB ✓
main-HASH.module.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 171 kB 171 kB ✓
commons.HASH.module.js gzip 55.4 kB 55.4 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 1.06 kB 1.06 kB ✓
hooks.js gzip 600 B 600 B ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.13 kB 8.13 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 429 B 429 B ✓
routerDirect.js gzip 292 B 292 B ✓
withRouter.js 439 B 439 B ✓
withRouter.js gzip 290 B 290 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 10.6 kB 10.6 kB ✓
_error.module.js gzip 4.31 kB 4.31 kB ✓
hooks.module.js 596 B 596 B ✓
hooks.module.js gzip 354 B 354 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.67 kB 3.67 kB ✓
routerDirect.module.js 417 B 417 B ✓
routerDirect.module.js gzip 292 B 292 B ✓
withRouter.module.js 427 B 427 B ✓
withRouter.module.js gzip 291 B 291 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.3 kB 66.3 kB ✓
hooks.html 2.87 kB 2.87 kB ✓
hooks.html gzip 865 B 864 B -1 B
index.js 248 kB 248 kB ✓
index.js gzip 66.6 kB 66.6 kB ⚠️ +1 B
link.js 255 kB 255 kB ✓
link.js gzip 68.8 kB 68.8 kB ⚠️ +1 B
routerDirect.js 248 kB 248 kB ✓
routerDirect.js gzip 66.5 kB 66.5 kB ⚠️ +1 B
withRouter.js 248 kB 248 kB ✓
withRouter.js gzip 66.6 kB 66.6 kB ⚠️ +1 B
Overall change ✓

@ijjk
Copy link
Member

ijjk commented Aug 16, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
buildDuration 26.9s 26.8s -59ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.56 kB 6.56 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 190 kB 190 kB ✓
commons.HASH.js gzip 61.6 kB 61.6 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.module.js 16.2 kB 16.2 kB ✓
main-HASH.module.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 171 kB 171 kB ✓
commons.HASH.module.js gzip 55.4 kB 55.4 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 1.06 kB 1.06 kB ✓
hooks.js gzip 600 B 600 B ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.13 kB 8.13 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 429 B 429 B ✓
routerDirect.js gzip 292 B 292 B ✓
withRouter.js 439 B 439 B ✓
withRouter.js gzip 290 B 290 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 10.6 kB 10.6 kB ✓
_error.module.js gzip 4.31 kB 4.31 kB ✓
hooks.module.js 596 B 596 B ✓
hooks.module.js gzip 354 B 354 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.67 kB 3.67 kB ✓
routerDirect.module.js 417 B 417 B ✓
routerDirect.module.js gzip 292 B 292 B ✓
withRouter.module.js 427 B 427 B ✓
withRouter.module.js gzip 291 B 291 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
link 2.8 kB 2.8 kB ✓
link gzip 850 B 850 B ✓
index 2.75 kB 2.75 kB ✓
index gzip 842 B 843 B ⚠️ +1 B
withRouter 2.81 kB 2.81 kB ✓
withRouter gzip 837 B 838 B ⚠️ +1 B
Overall change ✓
Serverless Mode
General
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
buildDuration 27.6s 28.3s ⚠️ +700ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.56 kB 6.56 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 190 kB 190 kB ✓
commons.HASH.js gzip 61.6 kB 61.6 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.module.js 16.2 kB 16.2 kB ✓
main-HASH.module.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 171 kB 171 kB ✓
commons.HASH.module.js gzip 55.4 kB 55.4 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 1.06 kB 1.06 kB ✓
hooks.js gzip 600 B 600 B ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.13 kB 8.13 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 429 B 429 B ✓
routerDirect.js gzip 292 B 292 B ✓
withRouter.js 439 B 439 B ✓
withRouter.js gzip 290 B 290 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 10.6 kB 10.6 kB ✓
_error.module.js gzip 4.31 kB 4.31 kB ✓
hooks.module.js 596 B 596 B ✓
hooks.module.js gzip 354 B 354 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.67 kB 3.67 kB ✓
routerDirect.module.js 417 B 417 B ✓
routerDirect.module.js gzip 292 B 292 B ✓
withRouter.module.js 427 B 427 B ✓
withRouter.module.js gzip 291 B 291 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.3 kB 66.3 kB ⚠️ +1 B
hooks.html 2.87 kB 2.87 kB ✓
hooks.html gzip 864 B 864 B ✓
index.js 248 kB 248 kB ✓
index.js gzip 66.6 kB 66.6 kB ✓
link.js 255 kB 255 kB ✓
link.js gzip 68.8 kB 68.8 kB ⚠️ +1 B
routerDirect.js 248 kB 248 kB ✓
routerDirect.js gzip 66.5 kB 66.5 kB ⚠️ +1 B
withRouter.js 248 kB 248 kB ✓
withRouter.js gzip 66.6 kB 66.6 kB ✓
Overall change ✓

@ijjk
Copy link
Member

ijjk commented Aug 16, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
buildDuration 26.8s 26s -744ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.56 kB 6.56 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 190 kB 190 kB ✓
commons.HASH.js gzip 61.6 kB 61.6 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.module.js 16.2 kB 16.2 kB ✓
main-HASH.module.js gzip 6.28 kB 6.28 kB -1 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 171 kB 171 kB ✓
commons.HASH.module.js gzip 55.4 kB 55.4 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 1.06 kB 1.06 kB ✓
hooks.js gzip 600 B 601 B ⚠️ +1 B
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.13 kB 8.13 kB ✓
link.js gzip 3.49 kB 3.49 kB -1 B
routerDirect.js 429 B 429 B ✓
routerDirect.js gzip 292 B 292 B ✓
withRouter.js 439 B 439 B ✓
withRouter.js gzip 290 B 289 B -1 B
Overall change ✓
Client Pages Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 10.6 kB 10.6 kB ✓
_error.module.js gzip 4.31 kB 4.31 kB ✓
hooks.module.js 596 B 596 B ✓
hooks.module.js gzip 354 B 354 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.67 kB 3.67 kB ✓
routerDirect.module.js 417 B 417 B ✓
routerDirect.module.js gzip 292 B 292 B ✓
withRouter.module.js 427 B 427 B ✓
withRouter.module.js gzip 291 B 291 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
link 2.8 kB 2.8 kB ✓
link gzip 850 B 852 B ⚠️ +2 B
index 2.75 kB 2.75 kB ✓
index gzip 843 B 844 B ⚠️ +1 B
withRouter 2.81 kB 2.81 kB ✓
withRouter gzip 837 B 839 B ⚠️ +2 B
Overall change ✓
Serverless Mode
General
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
buildDuration 27.6s 28.4s ⚠️ +876ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.56 kB 6.56 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 190 kB 190 kB ✓
commons.HASH.js gzip 61.6 kB 61.6 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.module.js 16.2 kB 16.2 kB ✓
main-HASH.module.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 171 kB 171 kB ✓
commons.HASH.module.js gzip 55.4 kB 55.4 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 1.06 kB 1.06 kB ✓
hooks.js gzip 600 B 600 B ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.13 kB 8.13 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 429 B 429 B ✓
routerDirect.js gzip 292 B 292 B ✓
withRouter.js 439 B 439 B ✓
withRouter.js gzip 290 B 290 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 10.6 kB 10.6 kB ✓
_error.module.js gzip 4.31 kB 4.31 kB ✓
hooks.module.js 596 B 596 B ✓
hooks.module.js gzip 354 B 354 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.67 kB 3.67 kB ✓
routerDirect.module.js 417 B 417 B ✓
routerDirect.module.js gzip 292 B 292 B ✓
withRouter.module.js 427 B 427 B ✓
withRouter.module.js gzip 291 B 291 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.3 kB 66.3 kB ✓
hooks.html 2.87 kB 2.87 kB ✓
hooks.html gzip 865 B 866 B ⚠️ +1 B
index.js 248 kB 248 kB ✓
index.js gzip 66.6 kB 66.6 kB -1 B
link.js 255 kB 255 kB ✓
link.js gzip 68.8 kB 68.8 kB ✓
routerDirect.js 248 kB 248 kB ✓
routerDirect.js gzip 66.5 kB 66.5 kB ✓
withRouter.js 248 kB 248 kB ✓
withRouter.js gzip 66.6 kB 66.6 kB -1 B
Overall change ✓

@ijjk
Copy link
Member

ijjk commented Aug 16, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
buildDuration 27.6s 28.3s ⚠️ +744ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.56 kB 6.56 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 190 kB 190 kB ✓
commons.HASH.js gzip 61.6 kB 61.6 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.module.js 16.2 kB 16.2 kB ✓
main-HASH.module.js gzip 6.28 kB 6.28 kB ⚠️ +1 B
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 171 kB 171 kB ✓
commons.HASH.module.js gzip 55.4 kB 55.4 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 1.06 kB 1.06 kB ✓
hooks.js gzip 601 B 600 B -1 B
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.13 kB 8.13 kB ✓
link.js gzip 3.49 kB 3.49 kB ⚠️ +1 B
routerDirect.js 429 B 429 B ✓
routerDirect.js gzip 292 B 292 B ✓
withRouter.js 439 B 439 B ✓
withRouter.js gzip 289 B 290 B ⚠️ +1 B
Overall change ✓
Client Pages Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 10.6 kB 10.6 kB ✓
_error.module.js gzip 4.31 kB 4.31 kB ✓
hooks.module.js 596 B 596 B ✓
hooks.module.js gzip 354 B 354 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.67 kB 3.67 kB ✓
routerDirect.module.js 417 B 417 B ✓
routerDirect.module.js gzip 292 B 292 B ✓
withRouter.module.js 427 B 427 B ✓
withRouter.module.js gzip 291 B 291 B ✓
Overall change ✓
Fetched pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
link 2.8 kB 2.8 kB ✓
link gzip 850 B 848 B -2 B
index 2.75 kB 2.75 kB ✓
index gzip 839 B 841 B ⚠️ +2 B
withRouter 2.81 kB 2.81 kB ✓
withRouter gzip 837 B 833 B -4 B
Overall change ✓
Serverless Mode
General
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
buildDuration 28.6s 29.3s ⚠️ +730ms
nodeModulesSize 41.3 MB 41.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.js 17.9 kB 17.9 kB ✓
main-HASH.js gzip 6.56 kB 6.56 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
commons.HASH.js 190 kB 190 kB ✓
commons.HASH.js gzip 61.6 kB 61.6 kB ✓
Overall change ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
main-HASH.module.js 16.2 kB 16.2 kB ✓
main-HASH.module.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH.module.js gzip 746 B 746 B ✓
commons.HASH.module.js 171 kB 171 kB ✓
commons.HASH.module.js gzip 55.4 kB 55.4 kB ✓
Overall change ✓
Client Pages
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.js 1.9 kB 1.9 kB ✓
_app.js gzip 905 B 905 B ✓
_error.js 12.1 kB 12.1 kB ✓
_error.js gzip 4.76 kB 4.76 kB ✓
hooks.js 1.06 kB 1.06 kB ✓
hooks.js gzip 600 B 600 B ✓
index.js 343 B 343 B ✓
index.js gzip 237 B 237 B ✓
link.js 8.13 kB 8.13 kB ✓
link.js gzip 3.49 kB 3.49 kB ✓
routerDirect.js 429 B 429 B ✓
routerDirect.js gzip 292 B 292 B ✓
withRouter.js 439 B 439 B ✓
withRouter.js gzip 290 B 290 B ✓
Overall change ✓
Client Pages Modern
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_app.module.js 1.79 kB 1.79 kB ✓
_app.module.js gzip 865 B 865 B ✓
_error.module.js 10.6 kB 10.6 kB ✓
_error.module.js gzip 4.31 kB 4.31 kB ✓
hooks.module.js 596 B 596 B ✓
hooks.module.js gzip 354 B 354 B ✓
index.module.js 319 B 319 B ✓
index.module.js gzip 238 B 238 B ✓
link.module.js 8.52 kB 8.52 kB ✓
link.module.js gzip 3.67 kB 3.67 kB ✓
routerDirect.module.js 417 B 417 B ✓
routerDirect.module.js gzip 292 B 292 B ✓
withRouter.module.js 427 B 427 B ✓
withRouter.module.js gzip 291 B 291 B ✓
Overall change ✓
Serverless bundles
zeit/next.js canary matamatak/next.js update_with-redux-thunk Change
_error.js 247 kB 247 kB ✓
_error.js gzip 66.3 kB 66.3 kB -1 B
hooks.html 2.87 kB 2.87 kB ✓
hooks.html gzip 866 B 866 B ✓
index.js 248 kB 248 kB ✓
index.js gzip 66.6 kB 66.6 kB -1 B
link.js 255 kB 255 kB ✓
link.js gzip 68.8 kB 68.8 kB ✓
routerDirect.js 248 kB 248 kB ✓
routerDirect.js gzip 66.5 kB 66.5 kB ✓
withRouter.js 248 kB 248 kB ✓
withRouter.js gzip 66.6 kB 66.6 kB ✓
Overall change ✓

lfades
lfades approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matamatak Thank you 🥇

@lfades lfades merged commit ab95c6d into vercel:canary Aug 16, 2019
lediepts
lediepts reviewed Sep 11, 2020
View reviewed changes
Copy link

@lediepts lediepts left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@matamatanot matamatanot deleted the update_with-redux-thunk branch October 30, 2021 09:54
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lediepts lediepts lediepts left review comments

@lfades lfades lfades approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matamatanot @ijjk @lfades @lediepts