Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting should be strict #9418

Merged
merged 2 commits into from Nov 15, 2019
Merged

Linting should be strict #9418

merged 2 commits into from Nov 15, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented Nov 15, 2019

This configures our linting to exit without a success status code when warnings are found.

@Timer
Linting should be strict
9a5c9eb 
This configures our linting to exit without a success status code when warnings are found
@Timer Timer added this to the 9.1.4 milestone Nov 15, 2019
@Timer Timer requested a review from lfades as a code owner November 15, 2019 06:39
@Timer Timer requested a review from ijjk November 15, 2019 06:40
@ijjk
Copy link
Member

ijjk commented Nov 15, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary Timer/next.js strict-linting Change
buildDuration 14.7s 14.8s ⚠️ +84ms
nodeModulesSize 48.8 MB 48.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js strict-linting Change
main-HASH.js 14.8 kB 14.8 kB ✓
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..a6fc245d9.js 19.8 kB 19.8 kB ✓
16b1a7225520..45d9.js gzip 7.28 kB 7.28 kB ✓
314e4c089430..de6eb480f.js 7.9 kB 7.9 kB ✓
314e4c089430..480f.js gzip 3.31 kB 3.31 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..39988e4af.js 33.1 kB 33.1 kB ✓
de003c3a9d30..e4af.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 213 kB 213 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js strict-linting Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.3 kB 5.3 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..85.module.js 16 kB 16 kB ✓
16b1a7225520..dule.js gzip 6.17 kB 6.17 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.43 kB 4.43 kB ✓
de003c3a9d30..36.module.js 22.2 kB 22.2 kB ✓
de003c3a9d30..dule.js gzip 8.71 kB 8.71 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 191 kB 191 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js strict-linting Change
polyfills-HASH.js 9.11 kB 9.11 kB ✓
polyfills-HASH.js gzip 3.11 kB 3.11 kB ✓
Overall change 9.11 kB 9.11 kB ✓
Client Pages
zeit/next.js canary Timer/next.js strict-linting Change
_app.js 7.71 kB 7.71 kB ✓
_app.js gzip 3.22 kB 3.22 kB ✓
_error.js 14.9 kB 14.9 kB ✓
_error.js gzip 5.57 kB 5.57 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 4.05 kB 4.05 kB ✓
link.js gzip 1.81 kB 1.81 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 29.7 kB 29.7 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js strict-linting Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 677 B 677 B ✓
hooks.module.js gzip 384 B 384 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 19.3 kB 19.3 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js strict-linting Change
_buildManifest.js 353 B 353 B ✓
_buildManifest.js gzip 260 B 260 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 604 B 604 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js strict-linting Change
index.html 3.9 kB 3.9 kB ✓
index.html gzip 1.01 kB 1.01 kB ✓
link.html 4.58 kB 4.58 kB ✓
link.html gzip 1.14 kB 1.14 kB ✓
withRouter.html 4.43 kB 4.43 kB ✓
withRouter.html gzip 1.08 kB 1.08 kB ✓
Overall change 12.9 kB 12.9 kB ✓
Serverless Mode
General
zeit/next.js canary Timer/next.js strict-linting Change
buildDuration 15.1s 14.8s -252ms
nodeModulesSize 48.8 MB 48.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js strict-linting Change
main-HASH.js 14.8 kB 14.8 kB ✓
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..a6fc245d9.js 19.8 kB 19.8 kB ✓
16b1a7225520..45d9.js gzip 7.28 kB 7.28 kB ✓
314e4c089430..de6eb480f.js 7.9 kB 7.9 kB ✓
314e4c089430..480f.js gzip 3.31 kB 3.31 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..39988e4af.js 33.1 kB 33.1 kB ✓
de003c3a9d30..e4af.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 213 kB 213 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js strict-linting Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.3 kB 5.3 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..85.module.js 16 kB 16 kB ✓
16b1a7225520..dule.js gzip 6.17 kB 6.17 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.43 kB 4.43 kB ✓
de003c3a9d30..36.module.js 22.2 kB 22.2 kB ✓
de003c3a9d30..dule.js gzip 8.71 kB 8.71 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 191 kB 191 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js strict-linting Change
polyfills-HASH.js 9.11 kB 9.11 kB ✓
polyfills-HASH.js gzip 3.11 kB 3.11 kB ✓
Overall change 9.11 kB 9.11 kB ✓
Client Pages
zeit/next.js canary Timer/next.js strict-linting Change
_app.js 7.71 kB 7.71 kB ✓
_app.js gzip 3.22 kB 3.22 kB ✓
_error.js 14.9 kB 14.9 kB ✓
_error.js gzip 5.57 kB 5.57 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 4.05 kB 4.05 kB ✓
link.js gzip 1.81 kB 1.81 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 29.7 kB 29.7 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js strict-linting Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 677 B 677 B ✓
hooks.module.js gzip 384 B 384 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 19.3 kB 19.3 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js strict-linting Change
_buildManifest.js 353 B 353 B ✓
_buildManifest.js gzip 260 B 260 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 604 B 604 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js strict-linting Change
_error.js 243 kB 243 kB ✓
_error.js gzip 64.8 kB 64.8 kB ✓
hooks.html 4.04 kB 4.04 kB ✓
hooks.html gzip 1.05 kB 1.05 kB ✓
index.js 244 kB 244 kB ✓
index.js gzip 65 kB 65 kB ✓
link.js 276 kB 276 kB ✓
link.js gzip 73.9 kB 73.9 kB ✓
routerDirect.js 269 kB 269 kB ✓
routerDirect.js gzip 71.9 kB 71.9 kB ✓
withRouter.js 269 kB 269 kB ✓
withRouter.js gzip 72 kB 72 kB ✓
Overall change 1.3 MB 1.3 MB ✓

Commit: 9a5c9eb

@ijjk
Copy link
Member

ijjk commented Nov 15, 2019

Stats from current PR

Default Server Mode
General
zeit/next.js canary Timer/next.js strict-linting Change
buildDuration 13.8s 14.1s ⚠️ +342ms
nodeModulesSize 48.8 MB 48.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js strict-linting Change
main-HASH.js 14.8 kB 14.8 kB ✓
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..a6fc245d9.js 19.8 kB 19.8 kB ✓
16b1a7225520..45d9.js gzip 7.28 kB 7.28 kB ✓
314e4c089430..de6eb480f.js 7.9 kB 7.9 kB ✓
314e4c089430..480f.js gzip 3.31 kB 3.31 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..39988e4af.js 33.1 kB 33.1 kB ✓
de003c3a9d30..e4af.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 213 kB 213 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js strict-linting Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.3 kB 5.3 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..85.module.js 16 kB 16 kB ✓
16b1a7225520..dule.js gzip 6.17 kB 6.17 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.43 kB 4.43 kB ✓
de003c3a9d30..36.module.js 22.2 kB 22.2 kB ✓
de003c3a9d30..dule.js gzip 8.71 kB 8.71 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 191 kB 191 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js strict-linting Change
polyfills-HASH.js 9.11 kB 9.11 kB ✓
polyfills-HASH.js gzip 3.11 kB 3.11 kB ✓
Overall change 9.11 kB 9.11 kB ✓
Client Pages
zeit/next.js canary Timer/next.js strict-linting Change
_app.js 7.71 kB 7.71 kB ✓
_app.js gzip 3.22 kB 3.22 kB ✓
_error.js 14.9 kB 14.9 kB ✓
_error.js gzip 5.57 kB 5.57 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 4.05 kB 4.05 kB ✓
link.js gzip 1.81 kB 1.81 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 29.7 kB 29.7 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js strict-linting Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 677 B 677 B ✓
hooks.module.js gzip 384 B 384 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 19.3 kB 19.3 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js strict-linting Change
_buildManifest.js 353 B 353 B ✓
_buildManifest.js gzip 260 B 260 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 604 B 604 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js strict-linting Change
index.html 3.9 kB 3.9 kB ✓
index.html gzip 1.01 kB 1.01 kB ✓
link.html 4.58 kB 4.58 kB ✓
link.html gzip 1.14 kB 1.14 kB ✓
withRouter.html 4.43 kB 4.43 kB ✓
withRouter.html gzip 1.08 kB 1.08 kB ✓
Overall change 12.9 kB 12.9 kB ✓
Serverless Mode
General
zeit/next.js canary Timer/next.js strict-linting Change
buildDuration 14.4s 14.4s ⚠️ +70ms
nodeModulesSize 48.8 MB 48.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js strict-linting Change
main-HASH.js 14.8 kB 14.8 kB ✓
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
16b1a7225520..a6fc245d9.js 19.8 kB 19.8 kB ✓
16b1a7225520..45d9.js gzip 7.28 kB 7.28 kB ✓
314e4c089430..de6eb480f.js 7.9 kB 7.9 kB ✓
314e4c089430..480f.js gzip 3.31 kB 3.31 kB ✓
commons.HASH.js 10.4 kB 10.4 kB ✓
commons.HASH.js gzip 3.91 kB 3.91 kB ✓
de003c3a9d30..39988e4af.js 33.1 kB 33.1 kB ✓
de003c3a9d30..e4af.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js 125 kB 125 kB ✓
framework.HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 213 kB 213 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js strict-linting Change
main-HASH.module.js 14.1 kB 14.1 kB ✓
main-HASH.module.js gzip 5.3 kB 5.3 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
16b1a7225520..85.module.js 16 kB 16 kB ✓
16b1a7225520..dule.js gzip 6.17 kB 6.17 kB ✓
4952ddcd88e7..cc.module.js 11.9 kB 11.9 kB ✓
4952ddcd88e7..dule.js gzip 4.43 kB 4.43 kB ✓
de003c3a9d30..36.module.js 22.2 kB 22.2 kB ✓
de003c3a9d30..dule.js gzip 8.71 kB 8.71 kB ✓
framework.HASH.module.js 125 kB 125 kB ✓
framework.HA..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 191 kB 191 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js strict-linting Change
polyfills-HASH.js 9.11 kB 9.11 kB ✓
polyfills-HASH.js gzip 3.11 kB 3.11 kB ✓
Overall change 9.11 kB 9.11 kB ✓
Client Pages
zeit/next.js canary Timer/next.js strict-linting Change
_app.js 7.71 kB 7.71 kB ✓
_app.js gzip 3.22 kB 3.22 kB ✓
_error.js 14.9 kB 14.9 kB ✓
_error.js gzip 5.57 kB 5.57 kB ✓
hooks.js 1.92 kB 1.92 kB ✓
hooks.js gzip 941 B 941 B ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 4.05 kB 4.05 kB ✓
link.js gzip 1.81 kB 1.81 kB ✓
routerDirect.js 411 B 411 B ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js 421 B 421 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 29.7 kB 29.7 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js strict-linting Change
_app.module.js 1.54 kB 1.54 kB ✓
_app.module.js gzip 759 B 759 B ✓
_error.module.js 10.5 kB 10.5 kB ✓
_error.module.js gzip 4.26 kB 4.26 kB ✓
hooks.module.js 677 B 677 B ✓
hooks.module.js gzip 384 B 384 B ✓
index.module.js 292 B 292 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 5.49 kB 5.49 kB ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect.module.js 399 B 399 B ✓
routerDirect..dule.js gzip 285 B 285 B ✓
withRouter.module.js 409 B 409 B ✓
withRouter.m..dule.js gzip 282 B 282 B ✓
Overall change 19.3 kB 19.3 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js strict-linting Change
_buildManifest.js 353 B 353 B ✓
_buildManifest.js gzip 260 B 260 B ✓
_buildManifest.module.js 251 B 251 B ✓
_buildManife..dule.js gzip 209 B 209 B ✓
Overall change 604 B 604 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js strict-linting Change
_error.js 243 kB 243 kB ✓
_error.js gzip 64.8 kB 64.8 kB ✓
hooks.html 4.04 kB 4.04 kB ✓
hooks.html gzip 1.05 kB 1.05 kB ✓
index.js 244 kB 244 kB ✓
index.js gzip 65 kB 65 kB ✓
link.js 276 kB 276 kB ✓
link.js gzip 73.9 kB 73.9 kB ✓
routerDirect.js 269 kB 269 kB ✓
routerDirect.js gzip 71.9 kB 71.9 kB ✓
withRouter.js 269 kB 269 kB ✓
withRouter.js gzip 72 kB 72 kB ✓
Overall change 1.3 MB 1.3 MB ✓

Commit: 995ee6c

@Timer Timer merged commit 34a38d2 into vercel:canary Nov 15, 2019
@Timer Timer deleted the strict-linting branch November 15, 2019 07:01
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @ijjk