Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable css support by default #9993

Closed
wants to merge 1 commit into from
Closed

Enable css support by default #9993

wants to merge 1 commit into from

Conversation

timneutkens
Copy link
Member

Checking if tests pass.

@ijjk
Copy link
Member

ijjk commented Jan 8, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/enable-css Change
buildDuration 11.3s 11.6s ⚠️ +349ms
nodeModulesSize 48.9 MB 48.9 MB -2 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/enable-css Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..7ed0.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/enable-css Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/enable-css Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/enable-css Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/enable-css Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/enable-css Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary timneutkens/next.js add/enable-css Change
index.html gzip 1.02 kB 1.02 kB ⚠️ +1 B
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.01 kB 1.01 kB -1 B
Overall change 3.06 kB 3.06 kB ✓

Diffs

Diff for index.html 
@@ -21,7 +21,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
+      href="/_next/static/runtime/webpack-d629b83a65f3e33fa99e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -109,13 +109,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
+      src="/_next/static/runtime/webpack-4d739ac7b0d8f888ab18.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
+      src="/_next/static/runtime/webpack-d629b83a65f3e33fa99e.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -21,7 +21,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
+      href="/_next/static/runtime/webpack-d629b83a65f3e33fa99e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -114,13 +114,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
+      src="/_next/static/runtime/webpack-4d739ac7b0d8f888ab18.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
+      src="/_next/static/runtime/webpack-d629b83a65f3e33fa99e.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -21,7 +21,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
+      href="/_next/static/runtime/webpack-d629b83a65f3e33fa99e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -109,13 +109,13 @@
       type="module"
     ></script
     ><script
-      src="/_next/static/runtime/webpack-a470c2a25bcb4d5a8ec0.js"
+      src="/_next/static/runtime/webpack-4d739ac7b0d8f888ab18.js"
       defer=""
       crossorigin="anonymous"
       nomodule=""
     ></script
     ><script
-      src="/_next/static/runtime/webpack-7928590be3ef2e55b835.module.js"
+      src="/_next/static/runtime/webpack-d629b83a65f3e33fa99e.module.js"
       defer=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/enable-css Change
buildDuration 11.6s 11.9s ⚠️ +332ms
nodeModulesSize 48.9 MB 48.9 MB -2 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/enable-css Change
main-HASH.js gzip 5.11 kB 5.11 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..7ed0.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 67.4 kB 67.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/enable-css Change
main-HASH.module.js gzip 4.17 kB 4.17 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 12.5 kB 12.5 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 62.1 kB 62.1 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/enable-css Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/enable-css Change
_app.js gzip 1.33 kB 1.33 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.9 kB 2.9 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.87 kB 9.87 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/enable-css Change
_app.module.js gzip 757 B 757 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.47 kB 2.47 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.41 kB 7.41 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/enable-css Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/enable-css Change
_error.js gzip 77.8 kB 77.7 kB -2 B
hooks.html gzip 1.05 kB 1.05 kB ⚠️ +1 B
index.js gzip 78 kB 78 kB -2 B
link.js gzip 80.4 kB 80.4 kB -2 B
routerDirect.js gzip 78 kB 78 kB -2 B
withRouter.js gzip 78.1 kB 78.1 kB -2 B
Overall change 393 kB 393 kB -9 B

Commit: 4368a02

ijjk
ijjk reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we found a few things that need updating in #9927 like the CSS support breaking first-paint performance data and AMP HMR failing from a non-AMP style tag being added

@timneutkens
Copy link
Member Author

Ah I missed that PR.

@timneutkens timneutkens closed this Jan 8, 2020
@timneutkens timneutkens deleted the add/enable-css branch February 12, 2021 13:33
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk left review comments

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timneutkens @ijjk