Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom 404 error page; dest not working if status is set #2453

Closed
thomasjsn opened this issue Jun 23, 2019 · 1 comment

Comments

2 participants
@thomasjsn
Copy link

commented Jun 23, 2019

I'm trying to define a custom 404 error page with the following routes in now.json:

"routes": [
  { "handle": "filesystem" },
  { "src": "/.*", "dest": "/404.html", "status": 404 }
]

But it doesn't work as expected.

  • If status is set, the dest page is not shown.
  • If status is not set; the dest page is shown, but with a status code of 200. Which is no good for a 404 error page.

It seems that the behaviour when having both dest and status has recently changed — previously I wasn't allowed, receiving the follow error message: Cannot use both status and dest.

Use usage of both dest and status is used in this documentation example: https://zeit.co/docs/v2/routing/directory-listing/

@paulogdm

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

We just fixed this. Thanks for the report @thomasjsn

@paulogdm paulogdm closed this Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.