Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch SourceNotFound error for domains transfer-in #1879

Merged
merged 1 commit into from Feb 6, 2019

Conversation

mglagola
Copy link
Member

@mglagola mglagola commented Feb 6, 2019

This catches an error when a user does not have billing info on file and attempts to transfer-in a domain.

@codecov-io
Copy link

Codecov Report

Merging #1879 into canary will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #1879      +/-   ##
=========================================
+ Coverage    6.34%   6.38%   +0.03%     
=========================================
  Files          93      93              
  Lines        4048    4041       -7     
=========================================
+ Hits          257     258       +1     
+ Misses       3791    3783       -8
Impacted Files Coverage Δ
src/util/read-metadata.js 100% <0%> (ø) ⬆️
src/util/hash.js 100% <0%> (ø) ⬆️
src/util/error.js 100% <0%> (ø) ⬆️
src/util/get-files.js 96.89% <0%> (+5.36%) ⬆️
src/util/get-project-name.js 100% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5999ec7...e449b51. Read the comment docs.

@javivelasco javivelasco merged commit 72142c3 into canary Feb 6, 2019
@javivelasco javivelasco deleted the add/billing-help-on-transfer-fail branch February 6, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants