Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue with original command after login #1935

wants to merge 2 commits into
base: canary


3 participants
Copy link

juliangruber commented Mar 6, 2019

Previously if the now-cli determined you would need to log in first in order to complete an action, it would exit after the login. With this change it continues with the command the user originally wished to run.

This means for example that a new user can run now and go through the whole sign up and deploy flow in one command.

This was implemented by creating a runCommand function which will be run in case we need to run the whole login command first.

Closes #1934.

@juliangruber juliangruber requested review from rauchg and leo Mar 6, 2019


This comment has been minimized.

Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #1935 into canary will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #1935      +/-   ##
- Coverage    6.35%   6.31%   -0.04%     
  Files          91      91              
  Lines        4062    4070       +8     
- Hits          258     257       -1     
- Misses       3804    3813       +9
Impacted Files Coverage Δ
src/index.js 0% <0%> (ø) ⬆️
src/commands/login.js 0% <0%> (ø) ⬆️
src/util/get-project-name.js 90.9% <0%> (-9.1%) ⬇️
src/util/get-files.js 91.53% <0%> (-5.37%) ⬇️
src/util/read-metadata.js 100% <0%> (ø) ⬆️
src/util/hash.js 100% <0%> (ø) ⬆️
src/util/error.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89bbdf...37a581e. Read the comment docs.


This comment has been minimized.

Copy link

rauchg commented Mar 6, 2019

With the new behavior, it would be really useful to:

  • Add tests so that we never regress
  • We add clear copy that says: > Log in first to deploy "~/rauchg/path"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.