Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored flow error checks #1953

Merged
merged 6 commits into from Mar 13, 2019

Conversation

4 participants
@juliangruber
Copy link
Collaborator

juliangruber commented Mar 12, 2019

No description provided.

@javivelasco
Copy link
Member

javivelasco left a comment

Looks like tests are failing but also I'm not sure about doing it in JS since we have no inference there. Let's try to do it first only in TS files and make sure it still compiles and infers the errors in the top level accordingly.

@juliangruber

This comment has been minimized.

Copy link
Collaborator Author

juliangruber commented Mar 12, 2019

I'm not sure about doing it in JS since we have no inference there. Let's try to do it first only in TS files and make sure it still compiles and infers the errors in the top level accordingly.

Isn't this only touching .ts files?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #1953 into canary will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #1953      +/-   ##
=========================================
- Coverage    6.31%   6.28%   -0.04%     
=========================================
  Files          90      90              
  Lines        4083    4090       +7     
=========================================
- Hits          258     257       -1     
- Misses       3825    3833       +8
Impacted Files Coverage Δ
src/util/get-project-name.js 90.9% <0%> (-9.1%) ⬇️
src/util/get-files.js 91.53% <0%> (-5.37%) ⬇️
src/util/read-metadata.js 100% <0%> (ø) ⬆️
src/util/hash.js 100% <0%> (ø) ⬆️
src/util/error.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952c369...da062db. Read the comment docs.

@leo
Copy link
Member

leo left a comment

I'm deferring to @javivelasco, who implemented this new error handling.

Show resolved Hide resolved src/commands/deploy/latest.js Outdated
Show resolved Hide resolved src/commands/alias/set.ts Outdated
Show resolved Hide resolved src/commands/alias/set.ts Outdated

@juliangruber juliangruber requested a review from javivelasco Mar 13, 2019

@leo

leo approved these changes Mar 13, 2019

@juliangruber juliangruber changed the title refactor flow error checks Refactored flow error checks Mar 13, 2019

@juliangruber juliangruber merged commit b3a70e9 into canary Mar 13, 2019

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details

@juliangruber juliangruber deleted the refactor/flow-error-checks branch Mar 13, 2019

leo added a commit that referenced this pull request Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.