Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the handling of user errors #1958

Merged
merged 6 commits into from Mar 13, 2019

Conversation

3 participants
@juliangruber
Copy link
Collaborator

juliangruber commented Mar 13, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #1958 into canary will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #1958      +/-   ##
=========================================
+ Coverage    6.31%   6.32%   +<.01%     
=========================================
  Files          90      90              
  Lines        4083    4082       -1     
=========================================
  Hits          258     258              
+ Misses       3825    3824       -1
Impacted Files Coverage Δ
src/index.js 0% <ø> (ø) ⬆️
src/util/report-error.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952c369...86a927d. Read the comment docs.

@juliangruber juliangruber requested review from leo and javivelasco Mar 13, 2019

@@ -693,6 +696,10 @@ function handleCreateDeployError(output, error) {
);
return 1;
}
if (error instanceof FileSizeLimitExceeded) {
output.error(`File size limit exceeded.`);

This comment has been minimized.

@juliangruber

juliangruber Mar 13, 2019

Author Collaborator

should there be a more user friendly error message here?

@leo
Copy link
Member

leo left a comment

The server is sending the size limit for the size limit error, I believe. So let's print that alongside the error in a nice manner.

juliangruber added some commits Mar 13, 2019

reverted file size limit check for this PR

@juliangruber juliangruber changed the title Fix the handling of user errors Fixed the handling of user errors Mar 13, 2019

@juliangruber juliangruber merged commit 0bfbd40 into canary Mar 13, 2019

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details

@juliangruber juliangruber deleted the fix/unexpected-user-errors branch Mar 13, 2019

leo added a commit that referenced this pull request Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.