Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the handling of user errors #1959

Merged
merged 4 commits into from Mar 15, 2019

Conversation

3 participants
@juliangruber
Copy link
Collaborator

juliangruber commented Mar 13, 2019

No description provided.

@juliangruber juliangruber requested a review from leo Mar 13, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #1959 into canary will decrease coverage by 0.26%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary   #1959      +/-   ##
=========================================
- Coverage    6.57%    6.3%   -0.27%     
=========================================
  Files          90      90              
  Lines        4092    4092              
=========================================
- Hits          269     258      -11     
- Misses       3823    3834      +11
Impacted Files Coverage Δ
src/commands/deploy/latest.js 0% <0%> (ø) ⬆️
src/commands/deploy/legacy.js 0% <0%> (ø) ⬆️
src/commands/scale.js 0% <0%> (ø) ⬆️
src/util/get-files.js 96.89% <0%> (-3.11%) ⬇️
src/util/read-metadata.js 100% <0%> (ø) ⬆️
src/util/get-project-name.js 100% <0%> (ø) ⬆️
src/util/report-error.js 0% <0%> (ø) ⬆️
src/util/hash.js 100% <0%> (ø) ⬆️
src/util/error.js 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b18ff...2bf89d8. Read the comment docs.

@juliangruber juliangruber changed the title fix unexpected `size_limit_exceeded` [WIP] Fix the handling of user errors Mar 13, 2019

super({
code: 'DEPLOYMENT_TYPE_UNSUPPORTED',
meta: {},
message: `This region only accepts Serverless Docker Deployments`

This comment has been minimized.

@juliangruber

juliangruber Mar 14, 2019

Author Collaborator

is that always the case with this error?

This comment has been minimized.

@leo

leo Mar 15, 2019

Member

@juliangruber I think we should say that only Now 2.0 deployments are supported?

This comment has been minimized.

@leo

leo Mar 15, 2019

Member

Oh, nevermind!

@juliangruber juliangruber changed the title [WIP] Fix the handling of user errors Fix the handling of user errors Mar 14, 2019

Show resolved Hide resolved src/commands/deploy/latest.js Outdated

@juliangruber juliangruber requested a review from leo Mar 15, 2019

@leo

leo approved these changes Mar 15, 2019

@leo leo merged commit 803b1ae into canary Mar 15, 2019

5 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details

@leo leo deleted the fix/file-size-limit-exceeded-error branch Mar 15, 2019

leo added a commit that referenced this pull request Mar 18, 2019

Fix the handling of user errors (#1959)
* fix unexpected `size_limit_exceeded`

* fix unexpected `deployment_type_unsupported`

* fix unexpected `JSONError`

* check if err.sizeLimit exists

leo added a commit that referenced this pull request Mar 18, 2019

leo added a commit that referenced this pull request Mar 19, 2019

Fix the handling of user errors (#1959)
* fix unexpected `size_limit_exceeded`

* fix unexpected `deployment_type_unsupported`

* fix unexpected `JSONError`

* check if err.sizeLimit exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.