Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic signup #2530

Merged
merged 10 commits into from Jul 12, 2019

Conversation

3 participants
@rdev
Copy link
Member

commented Jul 11, 2019

This PR disables automatic signup if an account with the email provided in now login doesn’t exist. Instead it shows an error message suggesting to create an account via zeit.co

Screen Shot 2019-07-12 at 12 25 21 am

@rdev rdev requested a review from leo Jul 11, 2019

@rdev rdev requested a review from TooTallNate as a code owner Jul 11, 2019

Show resolved Hide resolved src/util/errors-ts.ts Outdated

@rdev rdev requested a review from leo Jul 11, 2019

rdev added some commits Jul 11, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 12, 2019

Codecov Report

Merging #2530 into canary will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2530      +/-   ##
==========================================
+ Coverage   13.01%   13.02%   +<.01%     
==========================================
  Files         256      256              
  Lines        9351     9354       +3     
  Branches     1059     1059              
==========================================
+ Hits         1217     1218       +1     
- Misses       8015     8017       +2     
  Partials      119      119
Impacted Files Coverage Δ
src/util/errors-ts.ts 45.61% <ø> (-0.22%) ⬇️
src/commands/login.js 0% <0%> (ø) ⬆️
src/util/login/login.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e95049...1f1bef7. Read the comment docs.

@leo

leo approved these changes Jul 12, 2019

@rdev rdev merged commit 1f81d80 into canary Jul 12, 2019

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details

@rdev rdev deleted the fix/mode-login branch Jul 12, 2019

AndyBitz added a commit that referenced this pull request Jul 12, 2019

Disable automatic signup (#2530)
* Disable automatic signup

* Use shorter error message

* Update tests

* Update tests with user info

* Create tmpDir before tests

* Tweak fixtures and assertions for new login

* Don't pre-create the test directory in CI

* Use `os.homedir` instead of `~` in tests

* Pre-create auth directory conditionally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.