Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for v1 deployments #106

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@anatrajkovska
Copy link
Member

commented Aug 3, 2019

This PR adds support for deploying v1 projects.

Usage:

// v2
const { createDeployment } = require('now-client');
// v1
const { createLegacyDeployment } = require('now-client');

I also added unit tests for creating deployments for both v1 and v2.

@anatrajkovska anatrajkovska requested review from arunoda, leo and rdev Aug 3, 2019

@anatrajkovska

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

@arunoda @leo @rdev Can someone please give me a feedback?

@rdev

rdev approved these changes Aug 9, 2019

@anatrajkovska anatrajkovska requested a review from rdev Aug 12, 2019

@rdev

rdev approved these changes Aug 12, 2019

Copy link
Member

left a comment

🔥

@rdev rdev merged commit 059bd4b into master Aug 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rdev rdev deleted the feat/implement-v1-support branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.