Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logout effect #630

Merged
merged 2 commits into from May 9, 2019

Conversation

2 participants
@rdev
Copy link
Member

commented May 9, 2019

This PR makes sure logout effect is properly disposed of, preventing a memory leak

@rdev rdev requested a review from leo May 9, 2019

@leo

leo approved these changes May 9, 2019

@leo leo merged commit dde590b into canary May 9, 2019

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
now-desktop #20190509.30 succeeded
Details

@leo leo deleted the fix/logout-effect-cleanup branch May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.