Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-used devDependencies continued #635

Merged
merged 2 commits into from May 13, 2019

Conversation

2 participants
@ijjk
Copy link
Member

commented May 12, 2019

This was closed because it looked like it broke Windows builds. From looking at the Azure run it looks like this was due to it being unable to download the certificate and might have been because the PR was opened against a fork and not a branch on the repo.

ijjk added some commits May 9, 2019

@ijjk ijjk requested review from leo and rdev May 12, 2019

@rdev

rdev approved these changes May 13, 2019

Copy link
Member

left a comment

Looks good 👍

@rdev rdev merged commit 6877512 into canary May 13, 2019

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
now-desktop #20190512.2 succeeded
Details

@rdev rdev deleted the rm/unused-devDeps branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.