Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy from main process #644

Merged
merged 4 commits into from Jun 3, 2019

Conversation

2 participants
@rdev
Copy link
Member

commented May 31, 2019

This PR moves deployment logic to the main process via now-client v4

@rdev rdev requested a review from leo May 31, 2019

@leo leo changed the title Deploy from main process [WIP] Deploy from main process Jun 3, 2019

rdev added some commits Jun 3, 2019

@leo

leo approved these changes Jun 3, 2019

Copy link
Member

left a comment

Looks great, but:

  • front makes CPU go to 90%, we need semaphores, possibly for file reading
  • Deduping a single file (if you drop it in) takes up to 5s
  • We need to heavily improve the deployment spinner, it barely moves at all, everything seems slow

@rdev rdev merged commit 842d701 into canary Jun 3, 2019

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
now-desktop #20190603.5 succeeded
Details

@rdev rdev deleted the add/deploy-from-main branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.