Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust vertical about window layout #678

Merged
merged 1 commit into from Jul 3, 2019

Conversation

2 participants
@rdev
Copy link
Member

commented Jul 2, 2019

This PR adjusts the vertical layout approach in the About view to enforce section height and not rely on element margins, which should consistently fix button jitter

Screen Recording 2019-07-03 at 4 19 02 AM 2019-07-03 04_20_09

@rdev rdev requested a review from evilrabbit Jul 2, 2019

@evilrabbit evilrabbit merged commit e7f6b45 into canary Jul 3, 2019

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
now-desktop #20190702.11 succeeded
Details

@evilrabbit evilrabbit deleted the fix/about-vertical-layout branch Jul 3, 2019

rdev added a commit that referenced this pull request Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.