Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to current update channel in fallback config #679

Merged
merged 4 commits into from Jul 3, 2019

Conversation

2 participants
@rdev
Copy link
Member

commented Jul 3, 2019

This ensures that fallback config defaults the update channel to the current version type

@rdev rdev requested a review from leo Jul 3, 2019

rdev added some commits Jul 3, 2019

@leo

leo approved these changes Jul 3, 2019

@rdev rdev merged commit 4710ba0 into canary Jul 3, 2019

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
now-desktop #20190703.12 succeeded
Details

@rdev rdev deleted the fix/default-update-channel branch Jul 3, 2019

rdev added a commit that referenced this pull request Jul 3, 2019

Default to current update channel in fallback config (#679)
* Default to current update channel in fallback config

* Fix auth config

* Get version from package.json

* Return newConfig object in fallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.