Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0 bug fixes #682

Merged
merged 2 commits into from Jul 4, 2019

Conversation

2 participants
@rdev
Copy link
Member

commented Jul 4, 2019

This PR fixes the following issues:

  • Property ‘token’ of undefined error reported in Sentry which is caused by a race condition
  • Use author event entity for avatar title in event stream

rdev added some commits Jul 4, 2019

@rdev rdev requested a review from leo Jul 4, 2019

@leo

leo approved these changes Jul 4, 2019

Copy link
Member

left a comment

:shipit:

@rdev rdev merged commit bc24f47 into canary Jul 4, 2019

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
now-desktop #20190704.2 succeeded
Details

@rdev rdev deleted the fix/sentry-issues branch Jul 4, 2019

rdev added a commit that referenced this pull request Jul 13, 2019

5.0 bug fixes (#682)
* Fix `undefined.token` Sentry error

* Use event author entity for avatar title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.