Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sapper Example #453

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@msweeneydev
Copy link
Member

commented Aug 1, 2019

This PR adds a Sapper example based off of the npx degit "sveltejs/sapper-template#webpack" my-sapper-app command.

The README follows the standard template but includes a note advising how they build script has been changed.

The manifest.json file has been updated so that the template is available at /new.

This PR has been tested with a deployment as well and is available at https://sapper.now-examples.now.sh/

@msweeneydev msweeneydev requested a review from leo Aug 1, 2019

@msweeneydev msweeneydev requested a review from timothyis as a code owner Aug 1, 2019

@leo

leo approved these changes Aug 1, 2019

@now

This comment has been minimized.

Copy link

commented Aug 1, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://now-examples-git-add-sapper-example.zeit.sh

@msweeneydev msweeneydev merged commit 50891af into master Aug 1, 2019

1 check passed

now Deployment has completed
Details

@msweeneydev msweeneydev deleted the add/sapper-example branch Aug 1, 2019

@msweeneydev msweeneydev referenced this pull request Aug 1, 2019
@Conduitry

This comment has been minimized.

Copy link

commented Aug 2, 2019

As far as I can tell, this tweet is rather misleading.

now.json is no longer needed. Works for static and dynamic equally, and even ./pages/apis
It benefits from automatic static optimization so your pages come from the edge :)
https://nextjs.org/blog/next-9#automatic-static-optimization

Exported Sapper sites are completely static files, and have always been hostable on Now and on a myriad of other services.

All this PR provides an example for is hosting an exported Sapper site on Now. Saying "You can have whatever dynamic API endpoints and routes you want, because once you export them to static files, we can host them" seems disingenuous. Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.