Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Jekyll example #464

Merged
merged 7 commits into from Aug 8, 2019

Conversation

@sarupbanskota
Copy link
Member

commented Aug 8, 2019

  • Remove jekyll from the install step — it's superfluous
  • Only require installing ruby on production — it breaks now dev
  • Use canonical way to do public
  • Use pretty permalinks to avoid .html suffix

sarupbanskota added some commits Aug 8, 2019

Remove jekyll from the install step
If we're bundling anyway in the following step, installing jekyll is a
superfluous step.
,
Only require installing ruby on production
now dev will complain about yum locally, otherwise
@now

This comment has been minimized.

Copy link

commented Aug 8, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://now-examples-git-sarup-fix-jekyll-example.zeit.sh

@styfle

styfle approved these changes Aug 8, 2019

Copy link
Member

left a comment

Amazing work, thanks!

jekyll/package.json Outdated Show resolved Hide resolved
Update jekyll/package.json
Co-Authored-By: Steven <steven@ceriously.com>
jekyll/package.json Show resolved Hide resolved
jekyll/_config.yml Show resolved Hide resolved
@styfle

styfle approved these changes Aug 8, 2019

@msweeneydev

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Works well, thank you @sarupbanskota!

@msweeneydev msweeneydev merged commit 862c9a4 into master Aug 8, 2019

1 check passed

now Deployment has completed
Details

@msweeneydev msweeneydev deleted the SARUP/fix-jekyll-example branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.