Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Friendly error message for aliasing to nested subdomains #875

Closed
nkzawa opened this issue Sep 18, 2017 · 3 comments
Closed

Friendly error message for aliasing to nested subdomains #875

nkzawa opened this issue Sep 18, 2017 · 3 comments
Assignees
@leo

Comments

@nkzawa
Copy link
Contributor

nkzawa commented Sep 18, 2017 •
edited 

> Error! Unknown error: Error: The supplied alias "foo.bar.now.sh" is not a valid hostname. Make sure it excludes http:// and slashes

The error happens when you add aliases by now alias with settings in now.json.
I think we should display a more friendly message if we don't support nested subdomains (we don't support it).
@nkzawa nkzawa changed the title Aliasing to nested subdomains Friendly error message for aliasing to nested subdomains Sep 18, 2017
@Qix- Qix- assigned leo Nov 10, 2017
@ppatel221
Copy link

Hey, im a student in an open source class looking to contribute to an open source project. Is it okay if i work on this?

@leo
Copy link
Contributor

leo commented Jan 4, 2018

@ppatel221 Sure! Would be awesome 😊

@ppatel221
Copy link

Any tips on how to get started with this?

@ayusheesingh-zz ayusheesingh-zz mentioned this issue Feb 25, 2018
Merged
@leo leo closed this as completed in #1140 Feb 26, 2018
TooTallNate pushed a commit that referenced this issue Aug 23, 2019
@styfle
[now-python] Use ncc before publishing to npm (#875)
66df087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leo leo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nkzawa @Qix- @leo @ppatel221