Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-client] Fix windows paths handling #2974

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@rdev
Copy link
Member

commented Sep 6, 2019

This PR ensures Windows path separators are handled properly (fixes #2972)

@rdev rdev requested a review from TooTallNate Sep 6, 2019

@rdev rdev requested a review from leo as a code owner Sep 6, 2019

@rdev rdev requested review from styfle and AndyBitz Sep 6, 2019

@styfle styfle changed the title Fix windows paths handling in now-client [now-client] Fix windows paths handling Sep 6, 2019

@styfle styfle added the now-client label Sep 6, 2019

@rdev rdev requested review from TooTallNate, AndyBitz and styfle Sep 7, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Sep 7, 2019

Codecov Report

Merging #2974 into canary will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2974      +/-   ##
==========================================
+ Coverage   13.28%   13.38%   +0.09%     
==========================================
  Files         268      268              
  Lines       10321    10342      +21     
  Branches     1223     1218       -5     
==========================================
+ Hits         1371     1384      +13     
- Misses       8888     8896       +8     
  Partials       62       62
Impacted Files Coverage Δ
src/util/metrics.ts 68.18% <0%> (-2.41%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 28.57% <0%> (+3.57%) ⬆️
src/util/prefer-v2-deployment.ts 61.9% <0%> (+5.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b3c1e...3e444d8. Read the comment docs.

@rdev rdev added the automerge label Sep 9, 2019

@kodiakhq kodiakhq bot merged commit 4445d5e into canary Sep 9, 2019

17 of 18 checks passed

kodiakhq: status ⛴ attempting to merge PR (waiting for checks: {'ci/circleci: coverage'})
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-once Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details

@kodiakhq kodiakhq bot deleted the fix/now-client-win-paths branch Sep 9, 2019

rdev added a commit that referenced this pull request Sep 9, 2019
[now-client] Fix windows paths handling (#2974)
* Fix windows paths handling in now-client

* Tweak windows paths  handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.