Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-client] Ignore `.env.*` files by default #3436

Merged
merged 4 commits into from Jan 6, 2020
Merged

Conversation

@AndyBitz
Copy link
Contributor

AndyBitz commented Dec 16, 2019

Ignore .env.* files by default.

PRODUCT-804

rdev added 2 commits Jan 6, 2020
@rdev rdev requested a review from styfle Jan 6, 2020
@rdev
rdev approved these changes Jan 6, 2020
@kodiakhq kodiakhq bot merged commit 9755847 into master Jan 6, 2020
19 checks passed
19 checks passed
kodiakhq: status ⛴ attempting to merge PR (merging)
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-once Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@kodiakhq kodiakhq bot deleted the now-client/ignore-env branch Jan 6, 2020
@Zertz

This comment has been minimized.

Copy link

Zertz commented Jan 10, 2020

@AndyBitz @styfle This change silently broke some of our deployments 😞

@jclvicerra

This comment has been minimized.

Copy link

jclvicerra commented Jan 14, 2020

Our deployments too. We are currently using dotenv-flow for the handling of env.

@Zertz

This comment has been minimized.

Copy link

Zertz commented Jan 14, 2020

I put together a quick (and terrible) hack. I renamed the file to .env-production and create a symlink to .env.production in the build script 😨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.