Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event order in CLI #3502

Merged
merged 3 commits into from Jan 6, 2020
Merged

Fix event order in CLI #3502

merged 3 commits into from Jan 6, 2020

Conversation

@rdev
Copy link
Member

rdev commented Jan 6, 2020

This should fix PRODUCT-893 and PRODUCT-941

@rdev rdev requested review from leo and TooTallNate as code owners Jan 6, 2020
rdev added 2 commits Jan 6, 2020
@rdev rdev requested review from AndyBitz and styfle as code owners Jan 6, 2020
@rdev rdev added the automerge label Jan 6, 2020
@kodiakhq kodiakhq bot merged commit b5142d9 into master Jan 6, 2020
19 checks passed
19 checks passed
kodiakhq: status ⛴ attempting to merge PR (merging)
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-once Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@kodiakhq kodiakhq bot deleted the fix/event-order branch Jan 6, 2020
kodiakhq bot added a commit that referenced this pull request Jan 7, 2020
Fixes an undefined length issue introduced by #3502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.