Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store file count on `file_count` event for future use #3505

Merged
merged 3 commits into from Jan 7, 2020

Conversation

@rdev
Copy link
Member

rdev commented Jan 6, 2020

Fixes an undefined length issue introduced by #3502

@rdev rdev requested a review from lucleray Jan 6, 2020
@rdev rdev requested review from leo and TooTallNate as code owners Jan 6, 2020
@rdev rdev added the automerge label Jan 7, 2020
@rdev rdev changed the title Store file count on `file_count` event for futute use Store file count on `file_count` event for future use Jan 7, 2020
Copy link
Member

lucleray left a comment

Looks good!

@kodiakhq kodiakhq bot merged commit a85f11a into master Jan 7, 2020
19 checks passed
19 checks passed
kodiakhq: status ⛴ attempting to merge PR (merging)
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-once Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #3505 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3505      +/-   ##
==========================================
- Coverage    14.6%   14.59%   -0.01%     
==========================================
  Files         267      267              
  Lines       10794    10798       +4     
  Branches     1485     1485              
==========================================
  Hits         1576     1576              
- Misses       9049     9053       +4     
  Partials      169      169
Impacted Files Coverage Δ
src/util/deploy/process-deployment.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090c3ef...c3f41be. Read the comment docs.

@kodiakhq kodiakhq bot deleted the fix/file-count-hoist branch Jan 7, 2020
@styfle styfle added the now-cli label Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.