Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-build-utils] Fix now dev to use system node #3509

Merged
merged 6 commits into from Jan 6, 2020

Conversation

@styfle
Copy link
Member

styfle commented Jan 6, 2020

This PR will use the system installed version of Node.js and avoid printing a warning or error if a discontinued version is selected.

This optimization was already in @now/node but for some reason it was never add to @now/next.

The reason why its relevant today is because the warnings turned into errors due to Node 8 deprecation and we don't have the "Project" in now dev so we don't know which version of node to select.

So instead of determining the version, now dev will always use node in the PATH and avoid printing warnings or errors. This also results in less FS reads since we no longer need to read package.json.

styfle added 2 commits Jan 6, 2020
@styfle styfle added the automerge label Jan 6, 2020
@styfle styfle requested a review from leo as a code owner Jan 6, 2020
styfle added 2 commits Jan 6, 2020
@styfle

This comment has been minimized.

Copy link
Member Author

styfle commented Jan 6, 2020

Force merging to get now dev tests working again

@styfle styfle merged commit ecb0c08 into master Jan 6, 2020
12 of 18 checks passed
12 of 18 checks passed
ci/circleci: test-integration-linux-now-dev-node-10 Your tests failed on CircleCI
Details
ci/circleci: test-integration-linux-now-dev-node-12 Your tests failed on CircleCI
Details
ci/circleci: test-integration-linux-now-dev-node-8 Your tests failed on CircleCI
Details
ci/circleci: test-integration-macos-now-dev-node-10 Your tests failed on CircleCI
Details
ci/circleci: test-integration-macos-now-dev-node-12 Your tests failed on CircleCI
Details
ci/circleci: test-integration-macos-now-dev-node-8 Your tests failed on CircleCI
Details
kodiakhq: status 🛑 cannot merge (failing required status checks: {'ci/circleci: test-integration-linux-now-dev-node-10', 'ci/circleci: test-integration-linux-now-dev-node-8', 'ci/circleci: test-integration-macos-now-dev-node-8', 'ci/circleci: test-integration-linux-now-dev-node-12', 'ci/circleci: test-integration-macos-now-dev-node-12', 'ci/circleci: test-integration-macos-now-dev-node-10'})
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-once Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@styfle styfle deleted the PRODUCT-837/fix-now-dev-node branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.