Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for frameworks and examples #3514

Merged
merged 28 commits into from Jan 7, 2020
Merged

Add API for frameworks and examples #3514

merged 28 commits into from Jan 7, 2020

Conversation

@AndyBitz
Copy link
Contributor

AndyBitz commented Jan 7, 2020

This adds a Next.js page to this repo with an API for the examples and the frameworks. This makes sure that the frameworks API always provides the latest data when it gets updated.

The API is not used for now, after it gets merged I'll add examples/ and when this is done we'll replace the existing frameworks and examples API with this one.

PRODUCT-944
PRODUCT-955

@now

This comment has been minimized.

Copy link

now bot commented Jan 7, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zeit/now/ailvkxwlx
Preview: https://now-sage-seven.now.sh

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #3514 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3514      +/-   ##
=========================================
+ Coverage   14.55%   14.6%   +0.04%     
=========================================
  Files         267     267              
  Lines       10773   10786      +13     
  Branches     1484    1484              
=========================================
+ Hits         1568    1575       +7     
- Misses       9036    9042       +6     
  Partials      169     169
Impacted Files Coverage Δ
src/util/dev/yarn-installer.ts 79.68% <0%> (-3.65%) ⬇️
src/util/dev/builder-cache.ts 77.88% <0%> (-1.62%) ⬇️
src/util/get-update-command.ts 9.37% <0%> (-0.63%) ⬇️
src/util/dev/builder.ts 65.29% <0%> (-0.6%) ⬇️
src/util/dev/server.ts 59.55% <0%> (-0.06%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 23.52% <0%> (+4.48%) ⬆️
src/util/prefer-v2-deployment.ts 60% <0%> (+4.89%) ⬆️
src/util/metrics.ts 68.18% <0%> (+6.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537d508...aebaa4e. Read the comment docs.

@AndyBitz AndyBitz marked this pull request as ready for review Jan 7, 2020
@AndyBitz AndyBitz requested review from leo and TooTallNate as code owners Jan 7, 2020
@AndyBitz AndyBitz requested review from lucleray and styfle Jan 7, 2020
package.json Outdated Show resolved Hide resolved
now.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
AndyBitz added 3 commits Jan 7, 2020
api/frameworks.ts Show resolved Hide resolved
api/package.json Outdated Show resolved Hide resolved
api/tsconfig.json Outdated Show resolved Hide resolved
Co-Authored-By: Steven <steven@ceriously.com>
@styfle
styfle approved these changes Jan 7, 2020
Copy link
Member

styfle left a comment

Looks good, nice job! 🎉

@AndyBitz AndyBitz merged commit 890de6a into master Jan 7, 2020
19 checks passed
19 checks passed
kodiakhq: status 🛑 cannot merge (missing automerge_label: 'automerge')
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-once Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@AndyBitz AndyBitz deleted the frameworks-update branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.