Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds manifest.json to examples folder #3536

Merged
merged 18 commits into from Jan 9, 2020
Merged

Adds manifest.json to examples folder #3536

merged 18 commits into from Jan 9, 2020

Conversation

@AndyBitz
Copy link
Contributor

AndyBitz commented Jan 9, 2020

  • Adds manifest.json to examples folder
  • Uses examples folder instead of now-examples repo
@now

This comment has been minimized.

Copy link

now bot commented Jan 9, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zeit/now/3frtz0bkv
Preview: https://now-git-fix-examples.zeit.now.sh

@AndyBitz AndyBitz marked this pull request as ready for review Jan 9, 2020
@AndyBitz AndyBitz requested review from leo and TooTallNate as code owners Jan 9, 2020
AndyBitz added 2 commits Jan 9, 2020

return response.json();
export async function getExampleList(): Promise<Example[]> {
return (Frameworks as Framework[])

This comment has been minimized.

Copy link
@styfle

styfle Jan 9, 2020

Member

What's the purpose of as here? Is this still an issue with @now/frameworks package?

This comment has been minimized.

Copy link
@AndyBitz

AndyBitz Jan 9, 2020

Author Contributor

@styfle yes, it's still a JSON file, I've tried to convert it, but ran into some problems, so I couldn't convert it yet

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #3536 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3536      +/-   ##
=========================================
- Coverage   14.73%   14.5%   -0.23%     
=========================================
  Files         267     267              
  Lines       10827   10800      -27     
  Branches     1501    1487      -14     
=========================================
- Hits         1595    1567      -28     
- Misses       9059    9062       +3     
+ Partials      173     171       -2
Impacted Files Coverage Δ
src/util/metrics.ts 61.53% <0%> (-17.78%) ⬇️
src/util/prefer-v2-deployment.ts 55.1% <0%> (-12.07%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 19.04% <0%> (-6.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b56b40...1be6903. Read the comment docs.


_Live Example: https://create-react-app.now-examples.now.sh_
_Live Example: https://create-react-app-functions.now-examples.now.sh/_

This comment has been minimized.

Copy link
@styfle

styfle Jan 9, 2020

Member

Is this correct? The readme is in the create-react-app directory but the example is create-react-app-functions domain?

This comment has been minimized.

Copy link
@AndyBitz

AndyBitz Jan 9, 2020

Author Contributor

Yes, create-react-app-functions has been renamed to create-react-app and the other one has been deleted, so the domain is correct

This comment has been minimized.

Copy link
@AndyBitz

AndyBitz Jan 9, 2020

Author Contributor

But I've deployed this one again and adjusted the URL

examples/scully/README.md Outdated Show resolved Hide resolved
...summary('/tmp/now-examples-master'),
]);
await extract('https://github.com/zeit/now/archive/master.zip', '/tmp');
const exampleList = summary('/tmp/now-master/examples');

This comment has been minimized.

Copy link
@styfle

styfle Jan 9, 2020

Member

Can we change this since we have a monorepo?

Thinking out loud.....could the files be compressed as part of the build script? Then there is no need to fetch from github each time? 🤔

This comment has been minimized.

Copy link
@AndyBitz

AndyBitz Jan 9, 2020

Author Contributor

The results are already cached for 24 hours on the edge

This comment has been minimized.

Copy link
@styfle

styfle Jan 9, 2020

Member

We could cache forever with immutable header if we had all of the file available at build time. Because this is simply ready from master which is what already happens with the github integration 💡

This comment has been minimized.

Copy link
@AndyBitz

AndyBitz Jan 9, 2020

Author Contributor

And if we'd made it at build time we'd make the lambdas larger and increase the build time

This comment has been minimized.

Copy link
@styfle

styfle Jan 9, 2020

Member

Perhaps each example could be its own lambda. Surely they are all under 50MB 🤔

Co-Authored-By: Shu Ding <ds303077135@gmail.com>
@styfle
styfle approved these changes Jan 9, 2020
@AndyBitz AndyBitz merged commit 2db627b into master Jan 9, 2020
20 checks passed
20 checks passed
kodiakhq: status 🛑 cannot merge (missing automerge_label: 'automerge')
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-linux-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-10 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-12 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-macos-now-dev-node-8 Your tests passed on CircleCI!
Details
ci/circleci: test-integration-once Your tests passed on CircleCI!
Details
ci/circleci: test-lint Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
now Deployment has completed
Details
@AndyBitz AndyBitz deleted the fix-examples branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.