Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-cli][now-client] (Major) Remove legacy code #3840

Merged
merged 20 commits into from Mar 2, 2020

Conversation

@AndyBitz
Copy link
Contributor

AndyBitz commented Feb 26, 2020

@AndyBitz AndyBitz marked this pull request as ready for review Feb 26, 2020
return [
cert.uid,
formatCertCn(cn, multiple),
formatExpirationDate(new Date(cert.expiration)),
cert.autoRenew ? 'yes' : 'no',
chalk.gray(ms(time.getTime() - new Date(cert.created).getTime()))
chalk.gray(ms(time.getTime() - new Date(cert.created).getTime())),

This comment has been minimized.

Copy link
@styfle

styfle Feb 26, 2020

Member

Nice catch with ms! Should this also say "ago" like the rm command?

This comment has been minimized.

Copy link
@styfle

styfle Feb 26, 2020

Member

I guess rm is using Date.now() but this one is given a time variable so maybe not 🤔

@now now bot temporarily deployed to Preview Feb 26, 2020 Inactive
Co-Authored-By: Steven <steven@ceriously.com>
@styfle
styfle approved these changes Feb 26, 2020
Copy link
Member

styfle left a comment

I have a couple additional comments but those are mostly nit picks.

Great work @AndyBitz! 🎉 🥇 🚀

@AndyBitz AndyBitz changed the title [now-cli][now-client] Remove legacy code [now-cli][now-client] (Major) Remove legacy code Feb 26, 2020
These shell commands are defined internally.  Type `help' to see this list.
Type `help name' to find out more about the function `name'.
Use `info bash' to find out more about the shell in general.
Use `man -k' or `info' to find out more about commands not in this list.

A star (*) next to a name means that the command is disabled.

 job_spec [&]                                                                             history [-c] [-d offset] [n] or history -anrw [filename] or history -ps arg [arg...]
 (( expression ))                                                                         if COMMANDS; then COMMANDS; [ elif COMMANDS; then COMMANDS; ]... [ else COMMANDS; ] >
 . filename [arguments]                                                                   jobs [-lnprs] [jobspec ...] or jobs -x command [args]
 :                                                                                        kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]
 [ arg... ]                                                                               let arg [arg ...]
 [[ expression ]]                                                                         local [option] name[=value] ...
 alias [-p] [name[=value] ... ]                                                           logout [n]
 bg [job_spec ...]                                                                        mapfile [-d delim] [-n count] [-O origin] [-s count] [-t] [-u fd] [-C callback] [-c q>
 bind [-lpsvPSVX] [-m keymap] [-f filename] [-q name] [-u name] [-r keyseq] [-x keyseq:>  popd [-n] [+N | -N]
 break [n]                                                                                printf [-v var] format [arguments]
 builtin [shell-builtin [arg ...]]                                                        pushd [-n] [+N | -N | dir]
 caller [expr]                                                                            pwd [-LP]
 case WORD in [PATTERN [| PATTERN]...) COMMANDS ;;]... esac                               read [-ers] [-a array] [-d delim] [-i text] [-n nchars] [-N nchars] [-p prompt] [-t t>
 cd [-L|[-P [-e]] [-@]] [dir]                                                             readarray [-d delim] [-n count] [-O origin] [-s count] [-t] [-u fd] [-C callback] [-c>
 command [-pVv] command [arg ...]                                                         readonly [-aAf] [name[=value] ...] or readonly -p
 compgen [-abcdefgjksuv] [-o option] [-A action] [-G globpat] [-W wordlist]  [-F functi>  return [n]
 complete [-abcdefgjksuv] [-pr] [-DEI] [-o option] [-A action] [-G globpat] [-W wordlis>  select NAME [in WORDS ... ;] do COMMANDS; done
 compopt [-o|+o option] [-DEI] [name ...]                                                 set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
 continue [n]                                                                             shift [n]
 coproc [NAME] command [redirections]                                                     shopt [-pqsu] [-o] [optname ...]
 declare [-aAfFgilnrtux] [-p] [name[=value] ...]                                          source filename [arguments]
 dirs [-clpv] [+N] [-N]                                                                   suspend [-f]
 disown [-h] [-ar] [jobspec ... | pid ...]                                                test [expr]
 echo [-neE] [arg ...]                                                                    time [-p] pipeline
 enable [-a] [-dnps] [-f filename] [name ...]                                             times
 eval [arg ...]                                                                           trap [-lp] [[arg] signal_spec ...]
 exec [-cl] [-a name] [command [arguments ...]] [redirection ...]                         true
 exit [n]                                                                                 type [-afptP] name [name ...]
 export [-fn] [name[=value] ...] or export -p                                             typeset [-aAfFgilnrtux] [-p] name[=value] ...
 false                                                                                    ulimit [-SHabcdefiklmnpqrstuvxPT] [limit]
 fc [-e ename] [-lnr] [first] [last] or fc -s [pat=rep] [command]                         umask [-p] [-S] [mode]
 fg [job_spec]                                                                            unalias [-a] name [name ...]
 for NAME [in WORDS ... ] ; do COMMANDS; done                                             unset [-f] [-v] [-n] [name ...]
 for (( exp1; exp2; exp3 )); do COMMANDS; done                                            until COMMANDS; do COMMANDS; done
 function name { COMMANDS ; } or name () { COMMANDS ; }                                   variables - Names and meanings of some shell variables
 getopts optstring name [arg]                                                             wait [-fn] [id ...]
 hash [-lr] [-p pathname] [-dt] [name ...]                                                while COMMANDS; do COMMANDS; done
 help [-dms] [pattern ...]                                                                { COMMANDS ; } from subcommand list since it's a global command
…ove-legacy-code
@pranaygp

This comment has been minimized.

Copy link
Contributor

pranaygp commented Feb 28, 2020

Codecov Report

Merging #3840 into master will increase coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3840      +/-   ##
==========================================
+ Coverage   15.40%   15.97%   +0.57%     
==========================================
  Files         277      227      -50     
  Lines       10292     8528    -1764     
  Branches     1472     1236     -236     
==========================================
- Hits         1585     1362     -223     
+ Misses       8520     6979    -1541     
  Partials      187      187              
Impacted Files Coverage Δ
src/util/projects/get-project-by-id-or-name.ts 0.00% <0.00%> (-33.34%) ⬇️
src/util/output/cmd.ts 66.66% <0.00%> (-16.67%) ⬇️
src/util/output/highlight.ts 66.66% <0.00%> (-16.67%) ⬇️
src/util/config/local-path.ts 66.66% <0.00%> (-13.34%) ⬇️
src/util/errors.ts 45.29% <0.00%> (-9.26%) ⬇️
src/util/get-files.ts 82.85% <0.00%> (-7.33%) ⬇️
src/util/output/create-output.ts 54.71% <0.00%> (-5.67%) ⬇️
src/util/secrets.js 0.00% <0.00%> (ø) ⬆️
src/commands/list.js 0.00% <0.00%> (ø) ⬆️
src/util/dev/server.ts 56.83% <0.00%> (ø) ⬆️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995aa6e...7aee542. Read the comment docs.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #3840 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3840      +/-   ##
==========================================
- Coverage   15.97%   15.97%   -0.01%     
==========================================
  Files         227      227              
  Lines        8536     8532       -4     
  Branches     1238     1237       -1     
==========================================
- Hits         1364     1363       -1     
+ Misses       6985     6982       -3     
  Partials      187      187
Impacted Files Coverage Δ
src/util/metrics.ts 68.18% <0%> (+6.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aee542...80d80fa. Read the comment docs.

@AndyBitz AndyBitz merged commit 99c4c32 into master Mar 2, 2020
16 checks passed
16 checks passed
Unit Tests (ubuntu-latest, 10)
Details
Unit Tests (ubuntu-latest, 12)
Details
Unit Tests (macos-latest, 10)
Details
Unit Tests (macos-latest, 12)
Details
Unit Tests (windows-latest, 10)
Details
Unit Tests (windows-latest, 12)
Details
Integration Tests
Details
Now CLI Tests (ubuntu-latest, 10)
Details
Now CLI Tests (ubuntu-latest, 12)
Details
`now dev` Tests (ubuntu-latest, 10)
Details
`now dev` Tests (ubuntu-latest, 12)
Details
`now dev` Tests (macos-latest, 10)
Details
`now dev` Tests (macos-latest, 12)
Details
Coverage
Details
kodiakhq: status 🛑 cannot merge (missing automerge_label: 'automerge')
Details
now Deployment has completed
Details
@AndyBitz AndyBitz deleted the now-cli/remove-legacy-code branch Mar 2, 2020
AndyBitz added a commit that referenced this pull request Mar 18, 2020
AndyBitz added a commit that referenced this pull request Mar 18, 2020
)

* Revert "[now-cli][now-client] (Major) Remove legacy code (#3840)"

* Remove get

* Add projectId to .now/project.json
AndyBitz added a commit that referenced this pull request Apr 6, 2020
…)" (#3939)"

This reverts commit 51d7242.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.