Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Add Dojo Example #3882

Merged
merged 7 commits into from Mar 25, 2020
Merged

[examples] Add Dojo Example #3882

merged 7 commits into from Mar 25, 2020

Conversation

@agubler
Copy link
Contributor

agubler commented Mar 5, 2020

Adds an example for Dojo applications with ZEIT Now.

{
"name": "Dojo",
"slug": "dojo",
"demo": "https://dojo.now-examples.now.sh",

This comment has been minimized.

Copy link
@agubler

agubler Mar 5, 2020

Author Contributor

Is deploying to https://dojo.now-examples.now.sh something that we need to do or is it something that happens automatically?

This comment has been minimized.

Copy link
@styfle

styfle Mar 13, 2020

Member

I think we do it manually, right @msweeneydev ?

@styfle styfle added the examples label Mar 5, 2020
@agubler

This comment has been minimized.

Copy link
Contributor Author

agubler commented Mar 15, 2020

Thanks @styfle, pr updated.

@styfle
styfle approved these changes Mar 15, 2020
@styfle styfle added the automerge label Mar 15, 2020
@agubler agubler force-pushed the agubler:dojo-example branch from 4772ac9 to 06f6596 Mar 24, 2020
@agubler

This comment has been minimized.

Copy link
Contributor Author

agubler commented Mar 24, 2020

Hi @styfle Is there anything else I need to do for this PR? I have pulled and pushed the latest master changes so it's no longer out of date (and reapplied the changes from review that I mistakenly "lost")

examples/dojo/README.md Outdated Show resolved Hide resolved
examples/dojo/README.md Outdated Show resolved Hide resolved
agubler and others added 4 commits Mar 24, 2020
Co-Authored-By: Steven <steven@ceriously.com>
Co-Authored-By: Andy <AndyBitz@users.noreply.github.com>
@styfle
styfle approved these changes Mar 25, 2020
Copy link
Member

styfle left a comment

Thanks!

@styfle styfle merged commit f5e0afd into zeit:master Mar 25, 2020
12 of 15 checks passed
12 of 15 checks passed
CLI (ubuntu-latest, 10) CLI (ubuntu-latest, 10)
Details
E2E E2E
Details
Dev (ubuntu-latest, 10)
Details
Unit (ubuntu-latest, 10)
Details
CLI (ubuntu-latest, 12) CLI (ubuntu-latest, 12)
Details
Dev (ubuntu-latest, 12)
Details
Unit (ubuntu-latest, 12)
Details
Dev (macos-latest, 10)
Details
Unit (macos-latest, 10)
Details
Dev (macos-latest, 12)
Details
Unit (macos-latest, 12)
Details
Unit (windows-latest, 10)
Details
Unit (windows-latest, 12)
Details
kodiakhq: status 🛑 cannot merge (failing required status checks: {'CLI (ubuntu-latest, 12)', 'E2E', 'CLI (ubuntu-latest, 10)'})
Details
now Deployment has completed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.